You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/14 05:52:27 UTC
[GitHub] [skywalking] BFergerson opened a new issue, #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
BFergerson opened a new issue, #9787:
URL: https://github.com/apache/skywalking/issues/9787
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In https://github.com/apache/skywalking/pull/7130 the Java agent started using OpenAPI definitions for endpoint URLs. I think the Node.js agent should as well.
### Use case
There is currently no ability to tell the difference between a POST and a GET EntrySpan with the same URL.
### Related issues
https://github.com/apache/skywalking/issues/7113
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9787:
URL: https://github.com/apache/skywalking/issues/9787#issuecomment-1278614410
That is another issue. Nodejs doesn't follow, as this recommendation is new actually.
Feel free to adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] BFergerson commented on issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
Posted by GitBox <gi...@apache.org>.
BFergerson commented on issue #9787:
URL: https://github.com/apache/skywalking/issues/9787#issuecomment-1278564861
You're right, I forgot this was moved from the agent to the backend. Why then do the Node.js tests not have the OpenAPI definitions?
Node.js Entry:
https://github.com/apache/skywalking-nodejs/blob/9ab3d0ec872337bd1cf54f43fe0c29cbcc66ca0f/tests/plugins/express/expected.data.yaml#L80-L101
Java Entry:
https://github.com/apache/skywalking-java/blob/02fc1aee94dd44fdf60e4892ca202809cf2d46c1/test/plugin/scenarios/okhttp-scenario/config/expectedData.yaml#L47-L64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
URL: https://github.com/apache/skywalking/issues/9787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9787:
URL: https://github.com/apache/skywalking/issues/9787#issuecomment-1278556147
#7130 did this at the backend, I think nodejs agent doesn't have to redo this again on the agent side? This regex matching is CPU costing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] BFergerson commented on issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
Posted by GitBox <gi...@apache.org>.
BFergerson commented on issue #9787:
URL: https://github.com/apache/skywalking/issues/9787#issuecomment-1278620556
Should this be done on the agent or backend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9787: [Feature] endpoint name grouping by OpenAPI definitions in Node.js agent
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9787:
URL: https://github.com/apache/skywalking/issues/9787#issuecomment-1278665907
The endpoint format should be changed on the agent side to follow the `{METHOD}:{URI}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org