You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/07/26 10:09:46 UTC
[GitHub] [incubator-pagespeed-mod] oschaaf opened a new pull request #2010: Clean up third_party/css_parser
oschaaf opened a new pull request #2010:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2010
Signed-off-by: Otto van der Schaaf <os...@we-amp.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2010: Clean up third_party/css_parser
Posted by GitBox <gi...@apache.org>.
oschaaf commented on pull request #2010:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2010#issuecomment-663977120
Let's enable unit testing for third_party/css_parser.
Mostly succeeds modulo:
```
[ FAILED ] ParserTest.unescape
[ FAILED ] ParserTest.value_validation
[ FAILED ] ParserTest.AcceptAllValues
[ FAILED ] ParserTest.AtFontFace
```
It looks like these tests haven't been maintained for a while, so some of it might get
challenging, as expected behaviour may need to be reverse engineered in some cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2010: Clean up third_party/css_parser
Posted by GitBox <gi...@apache.org>.
oschaaf merged pull request #2010:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org