You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/21 04:32:28 UTC
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #35: Markfile and changelog
tzssangglass opened a new pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35
feat: add Makefile and CHANGELOG.md
fix: update the-internal-of-apisix-java-plugin-runner.png
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r658419860
##########
File path: Makefile
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig ./dist/$(RELEASE_SRC).tgz
Review comment:
Need to doc it in the Makefile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655192511
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
+- the test cases cover the codec. [#14](https://github.com/apache/apisix-java-plugin-runner/pull/14)
+- the test cases cover the filter. [#15](https://github.com/apache/apisix-java-plugin-runner/pull/15)
+- supported debug mode.
Review comment:
Where is the debug mode? I could not find it in the doc.
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
Review comment:
What does "complete joint debug" mean?
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
Review comment:
Normally, we don't include doc/test in the Core section.
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
Review comment:
This release mainly provides basic features and adds test cases.
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#SHELL := /bin/bash -o pipefail
Review comment:
Why comment out this line?
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
Look like we can only package source files into the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass edited a comment on pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass edited a comment on pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-864721810
@spacewander @dmsolr pls review
I'm not sure if this is the branch that should be renamed `release/0.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655192511
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
+- the test cases cover the codec. [#14](https://github.com/apache/apisix-java-plugin-runner/pull/14)
+- the test cases cover the filter. [#15](https://github.com/apache/apisix-java-plugin-runner/pull/15)
+- supported debug mode.
Review comment:
Where is the debug mode? I could not find it in the doc.
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
Review comment:
What does "complete joint debug" mean?
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
Review comment:
Normally, we don't include doc/test in the Core section.
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
Review comment:
This release mainly provides basic features and adds test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-867736360
@spacewander this PR is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655283234
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#SHELL := /bin/bash -o pipefail
Review comment:
my mistake, update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655281594
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
+- the test cases cover the codec. [#14](https://github.com/apache/apisix-java-plugin-runner/pull/14)
+- the test cases cover the filter. [#15](https://github.com/apache/apisix-java-plugin-runner/pull/15)
+- supported debug mode.
Review comment:
I mean this https://github.com/apache/apisix-java-plugin-runner/blob/main/docs/how-it-works.md#debug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655284802
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
Review comment:
I want to express that it works well with APISIX. now, I used `complete united test with [APISIX](https://github.com/apache/apisix).`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r656322862
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-864721810
@spacewander @dmsolr pls review
I'm not sure if this is the branch that should be renamed release/0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] dmsolr commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655827192
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
In general, we will publish the binary package and resource code package.
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
The package, mvn package generated,`./dist/apache-apisix-runner-bin.tar.gz`, is a publishable package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655193609
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#SHELL := /bin/bash -o pipefail
Review comment:
Why comment out this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655283728
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
Review comment:
remove those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-866739845
@dmsolr pls review it, I've separated the binary build from the source build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655803426
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
Look like we can only package source files into the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] dmsolr commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655827192
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
In general, we will publish the binary package and resource code package.
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig $(RELEASE_SRC).tgz
+ shasum -a 512 $(RELEASE_SRC).tgz > $(RELEASE_SRC).tgz.sha512
+
+ mkdir -p release
+ mv $(RELEASE_SRC).tgz release/$(RELEASE_SRC).tgz
+ mv $(RELEASE_SRC).tgz.asc release/$(RELEASE_SRC).tgz.asc
+ mv $(RELEASE_SRC).tgz.sha512 release/$(RELEASE_SRC).tgz.sha512
+
+.PHONY: compress-tar
+compress-tar:
+ ./mvnw package
Review comment:
The package, mvn package generated,`./dist/apache-apisix-runner-bin.tar.gz`, is a publishable package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#issuecomment-866757950
do we still need to keep the code about with the binary build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r658411698
##########
File path: Makefile
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig ./dist/$(RELEASE_SRC).tgz
Review comment:
can try `make release-src VERSION=0.1.0-SNAPSHOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] spacewander commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r658401936
##########
File path: Makefile
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig ./dist/$(RELEASE_SRC).tgz
Review comment:
I try `VERSION=0.1 make release-src`,
get:
```
gpg --batch --yes --armor --detach-sig ./dist/apache-apisix-java-plugin-runner-0.1-src.tgz
gpg: can't open './dist/apache-apisix-java-plugin-runner-0.1-src.tgz': No such file or directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r655281594
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
+- the test cases cover the codec. [#14](https://github.com/apache/apisix-java-plugin-runner/pull/14)
+- the test cases cover the filter. [#15](https://github.com/apache/apisix-java-plugin-runner/pull/15)
+- supported debug mode.
Review comment:
I mean this https://github.com/apache/apisix-java-plugin-runner/blob/main/docs/how-it-works.md#debug
##########
File path: Makefile
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+#SHELL := /bin/bash -o pipefail
Review comment:
my mistake, update
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
+- mecessary documentation. [#19](https://github.com/apache/apisix-java-plugin-runner/pull/19)
Review comment:
remove those
##########
File path: CHANGELOG.md
##########
@@ -0,0 +1,47 @@
+---
+title: Changelog
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Table of Contents
+
+- [0.1.0](#010)
+
+## 0.1.0
+
+This release mainly improve basic features, bugfix and adds test cases.
+
+### Core
+
+- complete project skeleton and available features.
+- complete joint debug with [APISIX](https://github.com/apache/apisix).
Review comment:
I want to express that it works well with APISIX. now, I used `complete united test with [APISIX](https://github.com/apache/apisix).`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #35: docs: add Markfile and Changelog.md
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #35:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/35#discussion_r658421437
##########
File path: Makefile
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SHELL := /bin/bash -o pipefail
+
+VERSION ?= latest
+RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+
+.PHONY: release-src
+release-src: compress-tar
+ gpg --batch --yes --armor --detach-sig ./dist/$(RELEASE_SRC).tgz
Review comment:
update `VERSION ?= latest` to `VERSION ?= 0.1.0-SNAPSHOT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org