You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:43:43 UTC

[GitHub] [parquet-mr] ggershinsky opened a new pull request #841: PARQUET-1939: Fix remote KMS client ambiguity

ggershinsky opened a new pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841


   1. rename this class to LocalWrapKmsClient; it will be used only in rare situations where in-server wrapping in not supported. In all other situations, the basic KmsClient interface will be used directly.
   
   2. this also means the "wrap.locally" property is not needed anymore, making the API slighly simpler.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky merged pull request #841: PARQUET-1939: Fix remote KMS client ambiguity

Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] ggershinsky commented on pull request #841: PARQUET-1939: Fix remote KMS client ambiguity

Posted by GitBox <gi...@apache.org>.
ggershinsky commented on pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841#issuecomment-722178335


   @gszadovszky Thanks for approving the #838. We have a couple of additional PRs - this one (841) and the #842, will appreciate their review. 
   There is nothing else in our pipelines.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky commented on pull request #841: PARQUET-1939: Fix remote KMS client ambiguity

Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841#issuecomment-725927739


   Re-triggering travis builds...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] gszadovszky closed pull request #841: PARQUET-1939: Fix remote KMS client ambiguity

Posted by GitBox <gi...@apache.org>.
gszadovszky closed pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] ggershinsky edited a comment on pull request #841: PARQUET-1939: Fix remote KMS client ambiguity

Posted by GitBox <gi...@apache.org>.
ggershinsky edited a comment on pull request #841:
URL: https://github.com/apache/parquet-mr/pull/841#issuecomment-722178335


   @gszadovszky Thanks for approving the #838. We have a couple of additional PRs - this one (841) and the #842, will appreciate their review. 
   There is nothing else in our pipelines for parquet-1.12.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org