[jira] [Commented] (HBASE-8003) Threads#getBoundedCachedThreadPool harcodes the time unit to seconds

["nkeywal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593251#comment-13593251 ] 

nkeywal commented on HBASE-8003:
--------------------------------

trivial patch, as it's always used with seconds today.
                
> Threads#getBoundedCachedThreadPool harcodes the time unit to seconds
> --------------------------------------------------------------------
>
>                 Key: HBASE-8003
>                 URL: https://issues.apache.org/jira/browse/HBASE-8003
>             Project: HBase
>          Issue Type: Bug
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Trivial
>         Attachments: 8003.v1.patch
>
>
>   /**
>    * Create a new CachedThreadPool with a bounded number as the maximum 
>    * thread size in the pool.
>    * 
>    * @param maxCachedThread the maximum thread could be created in the pool
>    * @param timeout the maximum time to wait
>    * @param unit the time unit of the timeout argument
>    * @param threadFactory the factory to use when creating new threads
>    * @return threadPoolExecutor the cachedThreadPool with a bounded number 
>    * as the maximum thread size in the pool. 
>    */
>   public static ThreadPoolExecutor getBoundedCachedThreadPool(
>       int maxCachedThread, long timeout, TimeUnit unit,
>       ThreadFactory threadFactory) {
>     ThreadPoolExecutor boundedCachedThreadPool =
>       new ThreadPoolExecutor(maxCachedThread, maxCachedThread, timeout,
>         TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(), threadFactory);
>     // allow the core pool threads timeout and terminate
>     boundedCachedThreadPool.allowCoreThreadTimeOut(true);
>     return boundedCachedThreadPool;
>   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira