You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/08/22 18:39:01 UTC
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14123
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
Hive 3 adds 'COLUMN_STATS_ACCURATE': '{}' to column statistics
during ALTER TABLE which lead to breaking this test, as it
expected the stats to be completely equal. Removing this
property before comparision solves the issue.
Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
---
M tests/metadata/test_hms_integration.py
1 file changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14123/1
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14123 )
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 18:52:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14123 )
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4333/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 19:20:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14123 )
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 18:57:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14123 )
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 23:04:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14123 )
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
Hive 3 adds 'COLUMN_STATS_ACCURATE': '{}' to column statistics
during ALTER TABLE which lead to breaking this test, as it
expected the stats to be completely equal. Removing this
property before comparision solves the issue.
Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Reviewed-on: http://gerrit.cloudera.org:8080/14123
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_hms_integration.py
1 file changed, 13 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8875: fix test drop column maintains stats with Hive 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14123 )
Change subject: IMPALA-8875: fix test_drop_column_maintains_stats with Hive 3
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4832/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2937e7634eca01e10492733102c834237ab6d6a
Gerrit-Change-Number: 14123
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 18:57:03 +0000
Gerrit-HasComments: No