You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2023/07/12 16:34:33 UTC

[GitHub] [spark] aokolnychyi commented on a diff in pull request #41962: [SPARK-44392][SQL][TESTS] Add tests for schema pruning in delta-based UPDATEs

aokolnychyi commented on code in PR #41962:
URL: https://github.com/apache/spark/pull/41962#discussion_r1261439274


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DeltaBasedMergeIntoTableSuiteBase.scala:
##########
@@ -215,18 +212,4 @@ abstract class DeltaBasedMergeIntoTableSuiteBase extends MergeIntoTableSuiteBase
           Row(3, 300, "china", "software"))) // insert
     }
   }
-
-  private def executeAndCheckScan(

Review Comment:
   Moving into the parent class to reuse for UPDATEs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org