You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/16 03:08:58 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #2087: type_id and value_offset are incorrect for sliced UnionArray
viirya opened a new pull request, #2087:
URL: https://github.com/apache/arrow-rs/pull/2087
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2086.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #2087: type_id and value_offset are incorrect for sliced UnionArray
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087#discussion_r922702220
##########
arrow/src/array/array_union.rs:
##########
@@ -383,6 +383,7 @@ mod tests {
use crate::array::*;
use crate::buffer::Buffer;
use crate::datatypes::{DataType, Field};
+ use crate::record_batch::RecordBatch;
Review Comment:
Hm? I need use `RecordBatch`, otherwise:
```
error[E0412]: cannot find type `RecordBatch` in this scope
--> arrow/src/array/array_union.rs:994:49
|
994 | fn test_slice_union(record_batch_slice: RecordBatch) {
| ^^^^^^^^^^^ not found in this scope
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2087: type_id and value_offset are incorrect for sliced UnionArray
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087#discussion_r922680530
##########
arrow/src/array/array_union.rs:
##########
@@ -956,4 +957,79 @@ mod tests {
let err = builder.append::<Int32Type>("a", 1).unwrap_err().to_string();
assert!(err.contains("Attempt to write col \"a\" with type Int32 doesn't match existing type Float32"), "{}", err);
}
+
+ #[test]
+ fn slice_union_array() {
+ // [1, null, 3.0, null, 4]
+ fn create_sparse_union() -> UnionArray {
+ let mut builder = UnionBuilder::new_sparse(5);
+ builder.append::<Int32Type>("a", 1).unwrap();
+ builder.append_null::<Int32Type>("a").unwrap();
+ builder.append::<Float64Type>("c", 3.0).unwrap();
+ builder.append_null::<Float64Type>("c").unwrap();
+ builder.append::<Int32Type>("a", 4).unwrap();
+ builder.build().unwrap()
+ }
+
+ // [1, null, 3.0, null, 4]
+ fn create_dense_union() -> UnionArray {
+ let mut builder = UnionBuilder::new_dense(5);
+ builder.append::<Int32Type>("a", 1).unwrap();
Review Comment:
Could conceivably rejig these methods to share the append code, but don't feel strongly
##########
arrow/src/array/array_union.rs:
##########
@@ -383,6 +383,7 @@ mod tests {
use crate::array::*;
use crate::buffer::Buffer;
use crate::datatypes::{DataType, Field};
+ use crate::record_batch::RecordBatch;
Review Comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2087: type_id and value_offset are incorrect for sliced UnionArray
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087#issuecomment-1186078551
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2087](https://codecov.io/gh/apache/arrow-rs/pull/2087?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6682b4f) into [master](https://codecov.io/gh/apache/arrow-rs/commit/cb7e5b0c8437c3f2ce2ae21951331599de4ccc7d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb7e5b0) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
+ Coverage 83.68% 83.70% +0.02%
==========================================
Files 224 224
Lines 58826 58900 +74
==========================================
+ Hits 49227 49302 +75
+ Misses 9599 9598 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2087?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow-rs/pull/2087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3VuaW9uLnJz) | `91.01% <100.00%> (+0.86%)` | :arrow_up: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `64.05% <0.00%> (-0.36%)` | :arrow_down: |
| [parquet/src/arrow/record\_reader/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/2087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvcmVjb3JkX3JlYWRlci9tb2QucnM=) | `89.17% <0.00%> (ø)` | |
| [parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/2087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfcmVhZGVyLnJz) | `92.76% <0.00%> (+0.09%)` | :arrow_up: |
| [arrow/src/ipc/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/2087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2lwYy93cml0ZXIucnM=) | `85.46% <0.00%> (+0.41%)` | :arrow_up: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2087/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.21% <0.00%> (+0.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2087?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2087?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb7e5b0...6682b4f](https://codecov.io/gh/apache/arrow-rs/pull/2087?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2087: type_id and value_offset are incorrect for sliced UnionArray
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087#issuecomment-1186260490
Benchmark runs are scheduled for baseline = a6379fe9818de3133a80700b7b8d6d9d59b29e37 and contender = 54e91811bd774b3c2dc8fdcf15c07b751256a5ed. 54e91811bd774b3c2dc8fdcf15c07b751256a5ed is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/791f639a7f6e42f3a4ffb9a10939fe46...e5d099ef334e49df88ddffd35abca9ad/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/aff4676a89cb43f4868ddff42f5d433a...307e8e2edac74c49b0525cc756fb0f66/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aacdb4e67f464781a62e585860ef3474...71bc2ca8399f4fd29267be5bd9075944/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c1e4b6fc30e84c178f6a5c1b7378555a...7127781c3423413bad54797d12bffd42/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2087: type_id and value_offset are incorrect for sliced UnionArray
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087#discussion_r922702372
##########
arrow/src/array/array_union.rs:
##########
@@ -383,6 +383,7 @@ mod tests {
use crate::array::*;
use crate::buffer::Buffer;
use crate::datatypes::{DataType, Field};
+ use crate::record_batch::RecordBatch;
Review Comment:
Oh, the diff rendered strangely on my phone - made it look like there were no other changes to this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2087: type_id and value_offset are incorrect for sliced UnionArray
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2087:
URL: https://github.com/apache/arrow-rs/pull/2087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org