You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/23 16:28:14 UTC
[GitHub] [beam] kennknowles opened a new pull request #14310: TestStream tests should be ValidatesRunner
kennknowles opened a new pull request #14310:
URL: https://github.com/apache/beam/pull/14310
I noticed that these are only marked NeedsRunner, so they will be missed when checking implementations by various runners.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806225610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805085843
run samza validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles edited a comment on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles edited a comment on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806318978
The failures in https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming_PR/286/ are on master; see https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/6184/. I didn't check the portable VR for Flink on the ParDoTest PR. I will open a separate PR to sickbay those, since they presumably were never working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806174683
From https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming_PR/284/, we should sickbay these failed tests from https://github.com/apache/beam/blob/master/runners/flink/job-server/flink_job_server.gradle#L171
Portable Spark streaming has been failed for a long time and it seems like this changes don't introduce new regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805130839
run spark validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806059668
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806318978
The failures are on master. I didn't check the portable VR for Flink on the ParDoTest PR. I will open a separate PR to sickbay those, since they presumably were never working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806060663
Run Java Spark PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805085384
run flink validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-807440438
Oups sorry I missed this PR not much to say given that Spark does not support `TestStream` yet, apart of that worth improvement :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805130721
run dataflow validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805127699
Added exclusions for failing VR tests, with Jiras.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805045912
R: @acrites I think you dealt with TestStream pretty recently too.
I noticed that these were not pulled in to ValidatesRunner suites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805129764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805085776
I think existing runners probably already have their exclude lists including the category since there are a couple of things that were annotated correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806334862
Run Java_Examples_Dataflow PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-806187790
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805161759
run samza validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles merged pull request #14310:
URL: https://github.com/apache/beam/pull/14310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805085457
run spark validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #14310: TestStream tests should be ValidatesRunner
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #14310:
URL: https://github.com/apache/beam/pull/14310#issuecomment-805154592
run samza validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org