[jira] [Commented] (PHOENIX-1643) Add default value for PColumn.getExpressionStr()

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308667#comment-14308667 ] 

James Taylor commented on PHOENIX-1643:
---------------------------------------

Thanks for the patch, [~tdsilva]. Looks very good, but the only thing I'm not crazy about is PColumnImpl.getExpressionStr() determining that it's an index versus table based on the column name. How about if we had a util like IndexUtil.getColumnExpression(PColumn), since we know when we're walking through index columns, right? Do we need to generate an expression string for the non index case as well?

Another alternative would be to push into PColumnImpl if it's for an index versus a table, but I'm not sure it's worth doing purely for this reason.

Thoughts?

> Add default value for PColumn.getExpressionStr()
> ------------------------------------------------
>
>                 Key: PHOENIX-1643
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1643
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.3
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 5.0.0, 4.3
>
>         Attachments: PHOENIX-1643.patch
>
>
> Add default value for PColumn.getExpressionStr() which defaults to the data table column name in order to maintain b/w compatibility for older clients (<4.3)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)