You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2006/11/03 00:44:17 UTC

[jira] Created: (HADOOP-677) RPC should send a fixed header and version at the start of connection

RPC should send a fixed header and version at the start of connection
---------------------------------------------------------------------

                 Key: HADOOP-677
                 URL: http://issues.apache.org/jira/browse/HADOOP-677
             Project: Hadoop
          Issue Type: Improvement
          Components: ipc
    Affects Versions: 0.7.2
            Reporter: Owen O'Malley
         Assigned To: Owen O'Malley
             Fix For: 0.9.0


There have been problems with http clients connecting to the RPC servers, which causes the RPC to try and allocate huge buffers and get OutOfMemoryExceptions. I want to have a fixed prefix that is sent first that identifies it as an RPC client. To make the system compatible as much as possible, I'd make the servers accept both forms for a Hadoop release and then change the clients to send the prefix, and finally make the servers only accept the new form.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-677) RPC should send a fixed header and version at the start of connection

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-677?page=all ]

Doug Cutting updated HADOOP-677:
--------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I just committed this.  Thanks, Owen!

> RPC should send a fixed header and version at the start of connection
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-677
>                 URL: http://issues.apache.org/jira/browse/HADOOP-677
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.7.2
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.9.0
>
>         Attachments: rpc-header.patch
>
>
> There have been problems with http clients connecting to the RPC servers, which causes the RPC to try and allocate huge buffers and get OutOfMemoryExceptions. I want to have a fixed prefix that is sent first that identifies it as an RPC client. To make the system compatible as much as possible, I'd make the servers accept both forms for a Hadoop release and then change the clients to send the prefix, and finally make the servers only accept the new form.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-677) RPC should send a fixed header and version at the start of connection

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-677?page=all ]

Owen O'Malley updated HADOOP-677:
---------------------------------

    Status: Patch Available  (was: Open)

> RPC should send a fixed header and version at the start of connection
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-677
>                 URL: http://issues.apache.org/jira/browse/HADOOP-677
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.7.2
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.9.0
>
>         Attachments: rpc-header.patch
>
>
> There have been problems with http clients connecting to the RPC servers, which causes the RPC to try and allocate huge buffers and get OutOfMemoryExceptions. I want to have a fixed prefix that is sent first that identifies it as an RPC client. To make the system compatible as much as possible, I'd make the servers accept both forms for a Hadoop release and then change the clients to send the prefix, and finally make the servers only accept the new form.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HADOOP-677) RPC should send a fixed header and version at the start of connection

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-677?page=all ]

Owen O'Malley updated HADOOP-677:
---------------------------------

    Attachment: rpc-header.patch

This patch causes the server to ignore a header on the start of ipc/rpc connections that look like:

"hrpc" <version byte>

The client has a static boolean variable about whether it should send such headers and it is currently set to false.

My plan is to have:
0.9: permissive server, old client
0.10: permissive server, new client
0.11: strict server, new client

If the hdfs protocol changes before 0.11, we can move to strict servers sooner. *smile*

> RPC should send a fixed header and version at the start of connection
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-677
>                 URL: http://issues.apache.org/jira/browse/HADOOP-677
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.7.2
>            Reporter: Owen O'Malley
>         Assigned To: Owen O'Malley
>             Fix For: 0.9.0
>
>         Attachments: rpc-header.patch
>
>
> There have been problems with http clients connecting to the RPC servers, which causes the RPC to try and allocate huge buffers and get OutOfMemoryExceptions. I want to have a fixed prefix that is sent first that identifies it as an RPC client. To make the system compatible as much as possible, I'd make the servers accept both forms for a Hadoop release and then change the clients to send the prefix, and finally make the servers only accept the new form.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira