You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/03/28 16:08:36 UTC
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/87
[OSGi] Graceful shutdown
Implement shutdown handler, call shutdown hooks at the appropriate time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server osgi/shutdown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 2acf8cf9679a15e1b4a0474b9e059655e59724c9
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-03-28T14:03:22Z
Graceful shutdown in OSGi
Implement shutdown handler, call shutdown hooks at the appropriate time.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202464979
config conflicts with some of the others, i think easily fixed in https://github.com/ahgittin/brooklyn-server/commit/b6b5fb62cec79a919dd00f4042d857337104ad75, but worth an eyeball that it is now all correct
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202781464
updated https://github.com/ahgittin/brooklyn-server/tree/all-osgi with everything including this and conflicts resolved. building and testing it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202741651
It was due to a missing commit 271d76ba08f411cb35ac85327a831c27b8276be6, had to force push to include it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202469982
builds fine for me so i think it's just a case that this has dependencies which aren't included in the PR
@neykov curious why you didn't build on the dependent PRs here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202506959
Actually the build failed when it got to the osgi init bundle (I spoke too soon, seeing core pass):
```
[INFO] Brooklyn OSGi init ................................ FAILURE [0.878s]
[INFO] Brooklyn Karaf .................................... SKIPPED
[INFO] Jetty config fragment ............................. SKIPPED
[INFO] Brooklyn Karaf Features ........................... SKIPPED
[INFO] Brooklyn Karaf Distro ............................. SKIPPED
[INFO] Brooklyn Karaf Shell Commands ..................... SKIPPED
[INFO] Brooklyn Karaf pax-exam itest ..................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:28.798s
[INFO] Finished at: Mon Mar 28 17:23:34 BST 2016
[INFO] Final Memory: 180M/580M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project brooklyn-karaf-init: Compilation failure: Compilation failure:
[ERROR] /private/tmp/brooklyn-server-71e8b35ca9680c4e1e443e883e4ba52c/karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/OsgiShutdownHandler.java:[21,37] cannot find symbol
[ERROR] symbol: class ShutdownHandler
[ERROR] location: package org.apache.brooklyn.core.mgmt
[ERROR] /private/tmp/brooklyn-server-71e8b35ca9680c4e1e443e883e4ba52c/karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/OsgiShutdownHandler.java:[28,45] cannot find symbol
[ERROR] symbol: class ShutdownHandler
[ERROR] /private/tmp/brooklyn-server-71e8b35ca9680c4e1e443e883e4ba52c/karaf/init/src/main/java/org/apache/brooklyn/launcher/osgi/OsgiShutdownHandler.java:[31,5] method does not override or implement a method from a supertype
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202466772
code looks nice and elegant. the jenkins compile failure is suspicious. building on my machine now.
personally don't like the name "container framework" -- that sounds like clocker to me -- but i'm guessing it's an osgi thing. references to it could say "osgi container framework" or something less ambiguous (but very minor.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202470485
Not basing on previous PRs because the changes in the PR get lost, harder to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: [OSGi] Graceful shutdown
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/87#issuecomment-202470195
Jenkins build failure due to the branch being based on master instead of previous PRs. Gave up piling one on the other :) - that's why there are minor merge conflicts here and there.
As for naming, agree that terms could be more descriptive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---