[jira] [Created] (HDFS-10118) CLONE - Erasure Coding: Fix FindBugs Multithreaded correctness Warning

["dragon (JIRA)" <ji...@apache.org>]

dragon created HDFS-10118:
-----------------------------

             Summary: CLONE - Erasure Coding: Fix FindBugs Multithreaded correctness Warning
                 Key: HDFS-10118
                 URL: https://issues.apache.org/jira/browse/HDFS-10118
             Project: Hadoop HDFS
          Issue Type: Sub-task
            Reporter: dragon
            Assignee: Rakesh R
             Fix For: HDFS-7285


Please find the findbug warnings [report|https://builds.apache.org/job/PreCommit-HDFS-Build/12444/artifact/patchprocess/patchFindbugsWarningshadoop-hdfs.html]

1) {code}
Bug type IS2_INCONSISTENT_SYNC (click for details) 
In class org.apache.hadoop.hdfs.DFSStripedInputStream
Field org.apache.hadoop.hdfs.DFSStripedInputStream.curStripeBuf
Synchronized 90% of the time
Unsynchronized access at DFSStripedInputStream.java:[line 829]
Synchronized access at DFSStripedInputStream.java:[line 183]
Synchronized access at DFSStripedInputStream.java:[line 186]
Synchronized access at DFSStripedInputStream.java:[line 184]
Synchronized access at DFSStripedInputStream.java:[line 382]
Synchronized access at DFSStripedInputStream.java:[line 460]
Synchronized access at DFSStripedInputStream.java:[line 461]
Synchronized access at DFSStripedInputStream.java:[line 461]
Synchronized access at DFSStripedInputStream.java:[line 285]
Synchronized access at DFSStripedInputStream.java:[line 297]
Synchronized access at DFSStripedInputStream.java:[line 298]
{code}

2) 
{code}
Unread field: org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock
Bug type URF_UNREAD_FIELD (click for details) 
In class org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo
Field org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock
At DFSStripedInputStream.java:[line 126]
{code}

3) 
{code}
Unchecked/unconfirmed cast from org.apache.hadoop.hdfs.protocol.LocatedBlock to org.apache.hadoop.hdfs.protocol.LocatedStripedBlock in org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock, BlockTokenIdentifier$AccessMode)
Bug type BC_UNCONFIRMED_CAST (click for details) 
In class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager
In method org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock, BlockTokenIdentifier$AccessMode)
Actual type org.apache.hadoop.hdfs.protocol.LocatedBlock
Expected org.apache.hadoop.hdfs.protocol.LocatedStripedBlock
Value loaded from b
At BlockManager.java:[line 974]
{code}

4) 
{code}
Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy, int, LocatedStripedBlock, long, long, ByteBuffer)
Bug type ICAST_INTEGER_MULTIPLY_CAST_TO_LONG (click for details) 
In class org.apache.hadoop.hdfs.util.StripedBlockUtil
In method org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy, int, LocatedStripedBlock, long, long, ByteBuffer)
At StripedBlockUtil.java:[line 375]
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)