You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/15 09:59:45 UTC
[GitHub] [shardingsphere] yy2so opened a new pull request, #21003: Update _index.en.md
yy2so opened a new pull request, #21003:
URL: https://github.com/apache/shardingsphere/pull/21003
Adding new committer avatar
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003#discussion_r971809070
##########
docs/community/content/team/_index.en.md:
##########
@@ -422,14 +422,19 @@ chapter = true
<img src="https://avatars.githubusercontent.com/u/64654203?v=4" style="border-radius:50%; overflow:hidden">
</a>
</td>
+ <td>
+ </a href="https://github.com/yy2so" target="_blank">
+ <img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
</tr>
<tr align="center">
<td>
<b>Junjie Zhang</b>
</td>
<td>
- <b>Swastika Gupta</b>
- </td>
+ <b>Swastika Gupta</b>
+ <td>
+ <b>Yacine Si Tayeb</b>
+ </tr>
Review Comment:
```suggestion
<b>Swastika Gupta</b>
</td>
<td>
<b>Yacine Si Tayeb</b>
</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003#discussion_r971811173
##########
docs/community/content/team/_index.en.md:
##########
@@ -422,13 +422,21 @@ chapter = true
<img src="https://avatars.githubusercontent.com/u/64654203?v=4" style="border-radius:50%; overflow:hidden">
</a>
</td>
+ <td>
+ <a href="https://github.com/yy2so" target="_blank">
+ <img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
Review Comment:
```suggestion
<img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003#discussion_r971806904
##########
docs/community/content/team/_index.en.md:
##########
@@ -422,14 +422,19 @@ chapter = true
<img src="https://avatars.githubusercontent.com/u/64654203?v=4" style="border-radius:50%; overflow:hidden">
</a>
</td>
+ <td>
+ </a href="https://github.com/yy2so" target="_blank">
+ <img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
Review Comment:
```suggestion
<td>
<a href="https://github.com/yy2so" target="_blank">
<img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
</a>
</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003#discussion_r971810467
##########
docs/community/content/team/_index.en.md:
##########
@@ -422,13 +422,21 @@ chapter = true
<img src="https://avatars.githubusercontent.com/u/64654203?v=4" style="border-radius:50%; overflow:hidden">
</a>
</td>
+ <td>
+ <a href="https://github.com/yy2so" target="_blank">
+ <img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
+ </a>
Review Comment:
```suggestion
<a href="https://github.com/yy2so" target="_blank">
<img src="https://avatars.githubusercontent.com/u/86716581?v=4" style="border-radius:50%; overflow:hidden">
</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yy2so commented on pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
yy2so commented on PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003#issuecomment-1247921798
>
@TeslaCN Done, updated CN version too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #21003: Update _index.en.md
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #21003:
URL: https://github.com/apache/shardingsphere/pull/21003#issuecomment-1247903452
Hi @yy2so
The _index.cn.md need to be updated too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org