You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/29 09:12:43 UTC

[GitHub] [shardingsphere] zjcnb opened a new issue #15186: InlineShardingAlgorithm partial logic need to add unit test.

zjcnb opened a new issue #15186:
URL: https://github.com/apache/shardingsphere/issues/15186


   Hi community,
   
   Refer to: #15110 , #15176 
   
   ```
       private String getTargetShardingNode(final Closure<?> closure, final String columnName) {
           try {
               return closure.call().toString();
           } catch (final MissingMethodException | NullPointerException ex) {
               throw new ShardingSphereException("Inline sharding algorithms expression `%s` and sharding column `%s` not match.", algorithmExpression, columnName);
           }
       }
   ```
   
   Please add unit test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #15186: InlineShardingAlgorithm partial logic need to add unit test.

Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #15186:
URL: https://github.com/apache/shardingsphere/issues/15186#issuecomment-1030518032


   @shankeerthan-kasilingam Welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] totalo closed issue #15186: InlineShardingAlgorithm partial logic need to add unit test.

Posted by GitBox <gi...@apache.org>.
totalo closed issue #15186:
URL: https://github.com/apache/shardingsphere/issues/15186


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] shankeerthan-kasilingam commented on issue #15186: InlineShardingAlgorithm partial logic need to add unit test.

Posted by GitBox <gi...@apache.org>.
shankeerthan-kasilingam commented on issue #15186:
URL: https://github.com/apache/shardingsphere/issues/15186#issuecomment-1030515458


   Hi,
   If it's open, can i try this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org