You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2013/12/05 19:17:53 UTC
git commit: CB-5584 Fix git clone of not working on windows.
Updated Branches:
refs/heads/master f6171761b -> feee3dfef
CB-5584 Fix git clone of not working on windows.
Suspect the issue was setting CWD to a tmp path before its created.
Based on pull request: https://github.com/apache/cordova-plugman/pull/16
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/feee3dfe
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/feee3dfe
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/feee3dfe
Branch: refs/heads/master
Commit: feee3dfef39af51d10518bb37e92b2eb6680d60e
Parents: f617176
Author: Andrew Grieve <ag...@chromium.org>
Authored: Thu Dec 5 13:16:39 2013 -0500
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Thu Dec 5 13:16:39 2013 -0500
----------------------------------------------------------------------
src/util/plugins.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/feee3dfe/src/util/plugins.js
----------------------------------------------------------------------
diff --git a/src/util/plugins.js b/src/util/plugins.js
index b21be86..afc261d 100644
--- a/src/util/plugins.js
+++ b/src/util/plugins.js
@@ -40,11 +40,11 @@ module.exports = {
shell.rm('-rf', tmp_dir);
- var cmd = util.format('git clone "%s" "%s"', plugin_git_url, path.basename(tmp_dir));
+ var cmd = util.format('git clone "%s" "%s"', plugin_git_url, tmp_dir);
require('../../plugman').emit('verbose', 'Fetching plugin via git-clone command: ' + cmd);
var d = Q.defer();
- child_process.exec(cmd, { cwd: path.dirname(tmp_dir) }, function(err, stdout, stderr) {
+ child_process.exec(cmd, function(err, stdout, stderr) {
if (err) {
d.reject(err);
} else {