You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Dmitry Zatselyapin (JIRA)" <ji...@apache.org> on 2009/08/28 04:54:59 UTC

[jira] Created: (WICKET-2440) ReuseIfModelObjectsEqualStrategy - Reuse Strategy for repeaters based on model objects

ReuseIfModelObjectsEqualStrategy - Reuse Strategy for repeaters based on model objects
--------------------------------------------------------------------------------------

                 Key: WICKET-2440
                 URL: https://issues.apache.org/jira/browse/WICKET-2440
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
         Environment: generic 
            Reporter: Dmitry Zatselyapin
            Priority: Minor


Add new reuse strategy that allows reuse models if model objects have not changed. The existing ReuseIfModelsEqualStrategy can also be used to accomplish this, you must override the model's equals/hashcode for proper implementation. Using ReuseIfModelObjectsEqualStrategy will require provide equals/hashcode methods only for model objects.  Models themselves do not have to be changed.  There are only tiny changes required to the ReuseIfModelsEqualStrategy to create this new strategy

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-2440) ReuseIfModelObjectsEqualStrategy - Reuse Strategy for repeaters based on model objects

Posted by "Dmitry Zatselyapin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Zatselyapin updated WICKET-2440:
---------------------------------------

    Attachment: ReuseIfModelObjectsEqualStrategy.java

based on version  3.5

> ReuseIfModelObjectsEqualStrategy - Reuse Strategy for repeaters based on model objects
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-2440
>                 URL: https://issues.apache.org/jira/browse/WICKET-2440
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>         Environment: generic 
>            Reporter: Dmitry Zatselyapin
>            Priority: Minor
>         Attachments: ReuseIfModelObjectsEqualStrategy.java
>
>
> Add new reuse strategy that allows reuse models if model objects have not changed. The existing ReuseIfModelsEqualStrategy can also be used to accomplish this, you must override the model's equals/hashcode for proper implementation. Using ReuseIfModelObjectsEqualStrategy will require provide equals/hashcode methods only for model objects.  Models themselves do not have to be changed.  There are only tiny changes required to the ReuseIfModelsEqualStrategy to create this new strategy

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-2440) ReuseIfModelObjectsEqualStrategy - Reuse Strategy for repeaters based on model objects

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2440.
-----------------------------------

    Resolution: Won't Fix
      Assignee: Igor Vaynberg

this is not a good thing to have in core as it leads to extremely bad practices. the use of a strategy like this can very easily lead to n+1 queries when dealing with database-driven dataviews.

> ReuseIfModelObjectsEqualStrategy - Reuse Strategy for repeaters based on model objects
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-2440
>                 URL: https://issues.apache.org/jira/browse/WICKET-2440
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>         Environment: generic 
>            Reporter: Dmitry Zatselyapin
>            Assignee: Igor Vaynberg
>            Priority: Minor
>         Attachments: ReuseIfModelObjectsEqualStrategy.java
>
>
> Add new reuse strategy that allows reuse models if model objects have not changed. The existing ReuseIfModelsEqualStrategy can also be used to accomplish this, you must override the model's equals/hashcode for proper implementation. Using ReuseIfModelObjectsEqualStrategy will require provide equals/hashcode methods only for model objects.  Models themselves do not have to be changed.  There are only tiny changes required to the ReuseIfModelsEqualStrategy to create this new strategy

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.