You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/01/31 13:28:10 UTC
[GitHub] [hadoop] steveloughran opened a new pull request #1827:
HADOOP-16835. Recover from all failures loading openssl native libs.
steveloughran opened a new pull request #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827
Change-Id: I6bdf8ac7a2a8ee82eda3eadac20f03888af24496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1827: HADOOP-16835.
Recover from all failures loading openssl native libs.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827#issuecomment-580750766
+ @DadanielZ @ThomasMarquardt @sahilTakiar .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1827: HADOOP-16835.
Recover from all failures loading openssl native libs.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827#issuecomment-613342838
superceded by #1948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran closed pull request #1827: HADOOP-16835.
Recover from all failures loading openssl native libs.
Posted by GitBox <gi...@apache.org>.
steveloughran closed pull request #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sahilTakiar commented on a change in pull request #1827:
HADOOP-16835. Recover from all failures loading openssl native libs.
Posted by GitBox <gi...@apache.org>.
sahilTakiar commented on a change in pull request #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827#discussion_r375390095
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory.java
##########
@@ -167,6 +167,15 @@ private void initializeSSLContext(SSLChannelMode preferredChannelMode)
LOG.debug("Failed to load OpenSSL. Falling back to the JSSE default.");
ctx = SSLContext.getDefault();
channelMode = SSLChannelMode.Default_JSSE;
+ } catch (Exception e) {
Review comment:
should we remove the `catch` block for the `NoSuchAlgorithmException` and just let all exceptions be handled by the same block? these changes look useful for the `NoSuchAlgorithmException` as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1827: HADOOP-16835.
Recover from all failures loading openssl native libs.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827#issuecomment-580733178
ran the abfs tests; failures fixed in #1821 and the "no http support " test, otherwise all good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1827: HADOOP-16835.
Recover from all failures loading openssl native libs.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1827: HADOOP-16835. Recover from all failures loading openssl native libs.
URL: https://github.com/apache/hadoop/pull/1827#issuecomment-580772623
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 18m 9s | trunk passed |
| +1 :green_heart: | compile | 16m 33s | trunk passed |
| +1 :green_heart: | checkstyle | 0m 48s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 22s | trunk passed |
| +1 :green_heart: | shadedclient | 14m 55s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 29s | trunk passed |
| +0 :ok: | spotbugs | 2m 3s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 1s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 46s | the patch passed |
| +1 :green_heart: | compile | 15m 50s | the patch passed |
| +1 :green_heart: | javac | 15m 50s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 50s | the patch passed |
| +1 :green_heart: | mvnsite | 1m 25s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 12m 44s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 32s | the patch passed |
| +1 :green_heart: | findbugs | 2m 9s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 18s | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. |
| | | 102m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1827/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1827 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux f613f926a1ad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / bf8686f |
| Default Java | 1.8.0_232 |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1827/1/testReport/ |
| Max. process+thread count | 1392 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1827/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org