You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/12/08 18:27:25 UTC

[GitHub] mistercrunch commented on a change in pull request #4030: make string conversion use utf8

mistercrunch commented on a change in pull request #4030: make string conversion use utf8
URL: https://github.com/apache/incubator-superset/pull/4030#discussion_r155842308
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -1300,9 +1300,9 @@ def get_data(self, df):
             for i, v in ys.iteritems():
                 x = i
                 if isinstance(x, (tuple, list)):
-                    x = ', '.join([str(s) for s in x])
+                    x = ', '.join([str(s.encode('utf8')) for s in x])
 
 Review comment:
   time to upgrade to py3!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services