You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/10 00:25:39 UTC
Review Request 44599: GEODE-1005 when multiple locators are started
same time, then they might endup creating two distributed system
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44599/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
Repository: geode
Description
-------
Now in findCoordinator call we give preference to member which has already created view.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 3d8b2e5
Diff: https://reviews.apache.org/r/44599/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 44599: GEODE-1005 when multiple locators are
started same
time, then they might endup creating two distributed system
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44599/#review122837
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 936)
<https://reviews.apache.org/r/44599/#comment184940>
You need to add some comments explaining the difference between coordinators and possibleCoordinators. Maybe coordinators should be renamed coordinatorsWithView.
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 975)
<https://reviews.apache.org/r/44599/#comment184937>
missing braces
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java (line 993)
<https://reviews.apache.org/r/44599/#comment184939>
missing braces
- Bruce Schuchardt
On March 9, 2016, 11:25 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44599/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 11:25 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Now in findCoordinator call we give preference to member which has already created view.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 3d8b2e5
>
> Diff: https://reviews.apache.org/r/44599/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>