You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/09/05 23:34:03 UTC
[GitHub] tajo pull request: TAJO-1818: Separate sql parser into an independ...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/733
TAJO-1818: Separate sql parser into an independent maven module.
This patch includes TAJO-1816 changes. It should be reviewed and committed after TAJO-1816.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/733.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #733
----
commit 7fef106b0d8766708ed36d37f6ff1cf30dadc5b1
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-09-05T12:07:57Z
TAJO-1816: Refactor SQL parser tests.
commit 82d789530cdb48a33345d66b31f37077142f5e96
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-09-05T12:20:05Z
Fixed wrong exception handling.
commit 821ec36e2ed02bba3b49121100f614accdd7a019
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-09-05T13:17:57Z
Removed resources/queries/default.
commit 61f23bb19b312c000d5393e427b031b87f579cc3
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-09-05T21:32:21Z
TAJO-1818: Separate sql parser into an independent maven module.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1818: Separate sql parser into an independ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/733#issuecomment-137997059
This patch just moves engine.parser pakcage into a separate maven module ``tajo-parser-sql``. So, its review will be easy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1818: Separate sql parser into an independ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1818: Separate sql parser into an independ...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/733#issuecomment-138210019
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1818: Separate sql parser into an independ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/733#issuecomment-138199527
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---