You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/23 10:57:52 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #3176: Solve
the problem of mv selector when there is having clause in query
EmmyMiao87 opened a new pull request #3176: Solve the problem of mv selector when there is having clause in query
URL: https://github.com/apache/incubator-doris/pull/3176
All of columns which belong to top of tupleIds in query shoud be considered in mv selecotr.
For example:
Select k1 from table group by k1 having sum(v1) >1;
The candidate index should contain k1 and v1 columns instread of only k1.
The rollup which only has k1 column should not be selected.
The issue ISSUE-3174 describe in detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3176: Solve the problem of mv selector when there is having clause in query
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3176: Solve the problem of mv selector when there is having clause in query
URL: https://github.com/apache/incubator-doris/pull/3176#discussion_r396405496
##########
File path: fe/src/main/java/org/apache/doris/analysis/TupleDescriptor.java
##########
@@ -256,6 +259,31 @@ public void materializeSlots() {
for (SlotDescriptor slot: slots) slot.setIsMaterialized(true);
}
+ public void getTableNameToColumnNames(Map<String, Set<String>> tupleDescToColumnNames) {
+ for (SlotDescriptor slotDescriptor : slots) {
+ if (slotDescriptor.isMaterialized() == false) {
Review comment:
```suggestion
if (!slotDescriptor.isMaterialized()) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3176: Solve the
problem of mv selector when there is having clause in query
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3176: Solve the problem of mv selector when there is having clause in query
URL: https://github.com/apache/incubator-doris/pull/3176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org