You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2023/12/22 11:19:18 UTC
[PR] Bump io.grpc:grpc-context from 1.59.0 to 1.60.1 [pinot]
dependabot[bot] opened a new pull request, #12198:
URL: https://github.com/apache/pinot/pull/12198
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.59.0 to 1.60.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-java/releases">io.grpc:grpc-context's releases</a>.</em></p>
<blockquote>
<h2>v1.60.1</h2>
<h1>Bug Fixes</h1>
<ul>
<li>util: Fix NPE when multiple addresses in an address group for petiole load balancer policies (<a href="https://redirect.github.com/grpc/grpc-java/issues/10770">#10770</a>)</li>
</ul>
<h2>v1.60.0</h2>
<h3>API Changes</h3>
<ul>
<li>api: Stabilize <code>ForwardingServerBuilder</code>, <code>ForwardingChannelBuilder2</code>, and <code>ForwardingChannelBuilder</code>. Note that <code>ForwardingChannelBuilder</code> is stabilized (no changes will be made to it), but immediately deprecated in favor of <code>ForwardingChannelBuilder2</code>. (<a href="https://redirect.github.com/grpc/grpc-java/issues/10586">#10586</a>)</li>
<li>api: Deprecate <code>ForwardingChannelBuilder.delegate()</code>. De facto this deprecates the class itself, since all classes extending <code>ForwardingChannelBuilder</code> implement the <code>delegate()</code> method. See javadoc for details (<a href="https://redirect.github.com/grpc/grpc-java/issues/10587">#10587</a>)</li>
<li>api: Changed recently-introduced <code>LoadBalancer.acceptResolvedAddresses()</code> to return <code>Status</code> instead of <code>boolean</code> (<a href="https://redirect.github.com/grpc/grpc-java/issues/10636">#10636</a>). This is part of continued work to align the LB API cross-language and API stabilization</li>
<li>stub: Deprecate StreamObservers (<a href="https://redirect.github.com/grpc/grpc-java/issues/10654">#10654</a>)</li>
<li>alts: AltsChannelBuilder now extends <code>ForwardingChannelBuilder2</code> (<a href="https://redirect.github.com/grpc/grpc-java/issues/10587">#10587</a>)</li>
<li>protobuf: Stabilize <code>ProtoUtils.metadataMarshaller()</code> (<a href="https://redirect.github.com/grpc/grpc-java/issues/10628">#10628</a>)</li>
<li>protobuf-lite: ProtoLiteUtils experimental comment (<a href="https://redirect.github.com/grpc/grpc-java/issues/10627">#10627</a>)</li>
</ul>
<h3>Behavior Changes</h3>
<ul>
<li>core: <code>ManagedChannel</code>s now check the address types provided by the nameResolver (for the given target) with the address types supported by the channel transport and generate an error in case of mismatch. That dramatically improves the error message when an issue occurs</li>
<li>core: When a server stream is closed due to user's code (an uncaught exception in halfClosed, messagesAvailable, onReady callback of a ServerStream's listener), the <code>Status.UNKNOWN</code> returned to the client will have <code>Application error processing RPC</code> description. Previously the description was empty. This is helpful to differentiate between server errors originated in user application, gRPC library, or even those injected by a proxy. (<a href="https://redirect.github.com/grpc/grpc-java/issues/10643">#10643</a>)</li>
<li>xds: Log ORCA UNIMPLEMENTED error to subchannel logger. This removes them from the normal application logs, reducing log spam</li>
</ul>
<h3>Improvements</h3>
<ul>
<li>Change the underlying implementations of RingHash, RoundRobin, WeightedRoundRobin and LeastRequest load balancers to utilize the pick first load balancer rather than directly manage subchannels. This should only be noticeable if it introduced a bug</li>
<li>core: Avoid flushing headers when the server returns a single response (<a href="https://redirect.github.com/grpc/grpc-java/issues/9314">#9314</a>). This is a performance optimization to reduce the number of packets for non-streaming responses</li>
<li>util: Make grpc-core an implementation dependency. This will prevent the io.grpc.internal classes in grpc-core from being visible during compilation when depending on just grpc-util</li>
<li>netty: Implement <code>Http2Headers.isEmpty()</code>. This fixes compatibility with Netty 4.1.101.Final.</li>
<li>netty: Add <code>NettyServerBuilder.maxRstFramesPerWindow()</code>. This can be used to limit impact of Rapid Reset</li>
<li>netty: Disable huffman coding in headers (<a href="https://redirect.github.com/grpc/grpc-java/issues/10563">#10563</a>). Huffman coding provides modest compression for relatively high CPU usage, especially within a data center. Rely just on the HPACK static and dynamic tables for compression, for higher performance. This only impacts header values 512 bytes or longer, as Netty already disabled Huffman for smaller values</li>
<li>alts: Improve handshake failure error message by propagating original exception (<a href="https://redirect.github.com/grpc/grpc-java/issues/10644">#10644</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>util: Remove shutdown subchannels from OD tracking (<a href="https://redirect.github.com/grpc/grpc-java/issues/10683">#10683</a>). This could have caused a memory leak on a long-lived channel. But we don’t think it could be triggered with our built-in load balancing policies.</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li>Bump Netty to 4.1.100.Final</li>
</ul>
<h3>Acknowledgements</h3>
<p><a href="https://github.com/anthonyjpratti"><code>@anthonyjpratti</code></a>
<a href="https://github.com/fedorka"><code>@fedorka</code></a>
<a href="https://github.com/jpd236"><code>@jpd236</code></a>
<a href="https://github.com/mateusazis"><code>@mateusazis</code></a>
<a href="https://github.com/pkoenig10"><code>@pkoenig10</code></a>
<a href="https://github.com/yannickepstein"><code>@yannickepstein</code></a>
<a href="https://github.com/amirhadadi"><code>@amirhadadi</code></a></p>
<h2>v1.59.1</h2>
<ul>
<li>netty: Implement <code>Http2Headers.isEmpty()</code>. This fixes compatibility with Netty 4.1.101.Final.</li>
<li>netty: Add <code>NettyServerBuilder.maxRstFramesPerWindow()</code>. This can be used to limit impact of Rapid Reset</li>
<li>xds: Log ORCA UNIMPLEMENTED error to subchannel logger. This removes them from the normal application logs, reducing log spam</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/grpc/grpc-java/commit/cd7ae8b61443fab5a0a737a6e78250669056d2e1"><code>cd7ae8b</code></a> Bump version to 1.60.1</li>
<li><a href="https://github.com/grpc/grpc-java/commit/ef294603da24d222655989802b45568455db376f"><code>ef29460</code></a> missed step</li>
<li><a href="https://github.com/grpc/grpc-java/commit/8b247598def25451e57da963343ac40e42a0403e"><code>8b24759</code></a> Bump version to 1.60.2-SNAPSHOT</li>
<li><a href="https://github.com/grpc/grpc-java/commit/09952f19d88b659ab3d61c9dfc74cafb52d3e8a0"><code>09952f1</code></a> Bump version to 1.60.2-SNAPSHOT</li>
<li><a href="https://github.com/grpc/grpc-java/commit/661dbe3f0de61dde648761632418699f17a44077"><code>661dbe3</code></a> Update README etc to reference 1.60.1</li>
<li><a href="https://github.com/grpc/grpc-java/commit/121f23f04d2802a466997e70f40b5a89fa4da665"><code>121f23f</code></a> Add increment as identified in <a href="https://redirect.github.com/grpc/grpc-java/issues/10768">#10768</a> (<a href="https://redirect.github.com/grpc/grpc-java/issues/10769">#10769</a>) (<a href="https://redirect.github.com/grpc/grpc-java/issues/10770">#10770</a>)</li>
<li><a href="https://github.com/grpc/grpc-java/commit/b758702bd954dd01a55fda185791dc045f2d6f66"><code>b758702</code></a> buildscripts: Use the Kokoro shared install lib from the new repo (<a href="https://redirect.github.com/grpc/grpc-java/issues/10757">#10757</a>) (#...</li>
<li><a href="https://github.com/grpc/grpc-java/commit/1f99df9494c0d18a429784c8a630d3a4cc7b08b9"><code>1f99df9</code></a> Bump version to 1.60.1-SNAPSHOT</li>
<li><a href="https://github.com/grpc/grpc-java/commit/eb8b1d8379008ab89cade89392d265bed90a2692"><code>eb8b1d8</code></a> Bump version to 1.60.0</li>
<li><a href="https://github.com/grpc/grpc-java/commit/5b1bb8cd859b5097c789e9e209edc6b7a97a88b0"><code>5b1bb8c</code></a> Update README etc to reference 1.60.0</li>
<li>Additional commits viewable in <a href="https://github.com/grpc/grpc-java/compare/v1.59.0...v1.60.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Bump io.grpc:grpc-context from 1.59.0 to 1.60.1 [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12198:
URL: https://github.com/apache/pinot/pull/12198#issuecomment-1867599210
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`9cfce82`)](https://app.codecov.io/gh/apache/pinot/commit/9cfce82385dfcd11eed4467c07f2409b76622d57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.54% compared to head [(`e9c127a`)](https://app.codecov.io/gh/apache/pinot/pull/12198?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 46.42%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #12198 +/- ##
=============================================
- Coverage 61.54% 46.42% -15.13%
+ Complexity 1152 946 -206
=============================================
Files 2407 1809 -598
Lines 130968 95158 -35810
Branches 20237 15352 -4885
=============================================
- Hits 80605 44175 -36430
- Misses 44470 47830 +3360
+ Partials 5893 3153 -2740
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.42% <ø> (-15.01%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.42% <ø> (-15.11%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.42% <ø> (-15.13%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.42% <ø> (-15.12%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.42% <ø> (-0.19%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/12198/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/12198?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Bump io.grpc:grpc-context from 1.59.0 to 1.60.1 [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #12198:
URL: https://github.com/apache/pinot/pull/12198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org