[GitHub] [spark] tomtongue commented on a diff in pull request #38268: [SPARK-40804][SQL] Missing handling a catalog name in destination tables in RenameTableExec

[GitBox <gi...@apache.org>]

tomtongue commented on code in PR #38268:
URL: https://github.com/apache/spark/pull/38268#discussion_r997128018


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableRenameSuite.scala:
##########
@@ -34,4 +34,15 @@ class AlterTableRenameSuite extends command.AlterTableRenameSuiteBase with Comma
       }
     }
   }
+
+  test("include catalog in the destination table") {
+    withNamespaceAndTable("ns", "dst_tbl", catalog) { dst =>
+      val src = dst.replace("dst", "src")
+      sql(s"CREATE TABLE $src (c0 INT) $defaultUsing")
+      sql(s"INSERT INTO $src SELECT 0")
+
+      sql(s"ALTER TABLE $src RENAME TO $catalog.ns.dst_tbl")

Review Comment:
   Thanks for checking this. I added the different catalog case and pushed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org