You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/06 14:43:40 UTC
[GitHub] [apisix-helm-chart] killix opened a new pull request, #340: feat: support vault configuration
killix opened a new pull request, #340:
URL: https://github.com/apache/apisix-helm-chart/pull/340
Support Vault integration configuration.
[Documentation](https://apisix.apache.org/blog/2022/01/21/apisix-hashicorp-vault-integration/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #340: feat: support vault configuration
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #340:
URL: https://github.com/apache/apisix-helm-chart/pull/340#issuecomment-1252094689
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #340: feat: support vault configuration
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #340:
URL: https://github.com/apache/apisix-helm-chart/pull/340#discussion_r964686123
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -253,6 +253,14 @@ data:
{{- end }}
{{- end }}
+ {{- if .Values.vault.enabled }}
Review Comment:
Also need to add them in values.yaml and README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #340: feat: support vault configuration
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #340:
URL: https://github.com/apache/apisix-helm-chart/pull/340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #340: feat: support vault configuration
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #340:
URL: https://github.com/apache/apisix-helm-chart/pull/340#issuecomment-1252093713
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #340: feat: support vault configuration
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #340:
URL: https://github.com/apache/apisix-helm-chart/pull/340#discussion_r967773745
##########
charts/apisix/values.yaml:
##########
@@ -439,3 +439,6 @@ dashboard:
ingress-controller:
enabled: false
+
+vault:
+ enabled: false
Review Comment:
I think you should list all configurable fields here, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org