You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/15 17:52:00 UTC

[PR] test(workflow-operator): pin ConnUtil URL composition without DriverManager [texera]

Ma77Ball opened a new pull request, #5728:
URL: https://github.com/apache/texera/pull/5728

   ### What changes were proposed in this PR?
   - `PostgreSQLConnUtilSpec` / `MySQLConnUtilSpec` were flaky: they ran a multi-step sequence against the process-global `java.sql.DriverManager` registry (deregister the real driver, register a capturing stub, restore), and the module's tests run un-forked with sbt's default `parallelExecution = true`, so the suites raced any concurrent suite that touched JDBC in the same JVM.
   - Extracted the JDBC URL composition (the only application-controlled logic) into a pure `buildJdbcUrl(host, port, database)` in `PostgreSQLConnUtil` and `MySQLConnUtil`; the existing `connect` now calls it, so the public signature and runtime behavior are unchanged.
   - Rewrote both specs to assert URL composition directly on `buildJdbcUrl`, with no `DriverManager` mutation and no `BeforeAndAfterAll`, so the suites are deterministic under parallel execution.
   - Dropped the former `setReadOnly` / credential / `SQLException` assertions: those exercise JDBC plumbing rather than application logic and were what forced the global-registry manipulation behind the flake.
   ### Any related issues, documentation, discussions?
   Closes: #5727
   ### How was this PR tested?
   - Run `sbt "WorkflowOperator/testOnly *PostgreSQLConnUtilSpec *MySQLConnUtilSpec"` (under JDK 17); expect 12 tests succeeded, 0 failed across 2 suites.
   - Run `sbt scalafmtCheckAll`; expect success (no formatting diffs).
   - The original race was timing-dependent and not reproducible on demand; the fix removes the shared `DriverManager` state entirely, so there is no longer cross-suite state to race. Reviewers can confirm by grepping the two specs for `DriverManager` and `BeforeAndAfterAll`, both now absent.
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.8 in compliance with ASF
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(workflow-operator): pin ConnUtil URL composition without DriverManager [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5728:
URL: https://github.com/apache/texera/pull/5728#issuecomment-4716914185

   @Yicong-Huang or @aglinxinyuan please merge when available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(workflow-operator): pin ConnUtil URL composition without DriverManager [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5728:
URL: https://github.com/apache/texera/pull/5728#issuecomment-4710814561

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5728?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 52.95%. Comparing base ([`891d2ad`](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`74dbd1e`](https://app.codecov.io/gh/apache/texera/commit/74dbd1e7c8e988cf93a545cef2c0c3ccdc7e41f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #5728      +/-   ##
   ============================================
   - Coverage     52.95%   52.95%   -0.01%     
     Complexity     2627     2627              
   ============================================
     Files          1090     1090              
     Lines         42210    42208       -2     
     Branches       4534     4534              
   ============================================
   - Hits          22353    22351       -2     
     Misses        18546    18546              
     Partials       1311     1311              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.91% <ø> (ø)` | | |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.11% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.71% <ø> (ø)` | | |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.06% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.93% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.77% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [python](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.73% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [891d2ad](https://app.codecov.io/gh/apache/texera/commit/891d2adbc8d096774121150eb079dfacdfded161?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5728?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(workflow-operator): pin ConnUtil URL composition without DriverManager [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5728:
URL: https://github.com/apache/texera/pull/5728#issuecomment-4713514274

   /request-review @Yicong-Huang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(workflow-operator): pin ConnUtil URL composition without DriverManager [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5728:
URL: https://github.com/apache/texera/pull/5728#issuecomment-4710838096

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 2 better · 🔴 2 worse · ⚪ 11 noise (<±5%) · 0 without baseline
   
   > Compared against main `891d2ad` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/27565463712)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 406 | 0.248 | 23,267/35,078/35,078 us | 🔴 +5.3% / ⚪ within ±5% |
   | 🟢 | bs=100 sw=10 sl=64 | 812 | 0.495 | 120,909/144,168/144,168 us | 🟢 -9.8% / 🔴 -9.1% |
   | ⚪ | bs=1000 sw=10 sl=64 | 943 | 0.575 | 1,065,812/1,098,107/1,098,107 us | ⚪ within ±5% / 🔴 +9.6% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `891d2ad` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 406 tuples/sec | 408 tuples/sec | 410.82 tuples/sec | -0.5% | -1.2% |
   | bs=10 sw=10 sl=64 | MB/s | 0.248 MB/s | 0.249 MB/s | 0.251 MB/s | -0.4% | -1.1% |
   | bs=10 sw=10 sl=64 | p50 | 23,267 us | 24,247 us | 23,785 us | -4.0% | -2.2% |
   | bs=10 sw=10 sl=64 | p95 | 35,078 us | 33,324 us | 34,980 us | +5.3% | +0.3% |
   | bs=10 sw=10 sl=64 | p99 | 35,078 us | 33,324 us | 34,980 us | +5.3% | +0.3% |
   | bs=100 sw=10 sl=64 | throughput | 812 tuples/sec | 810 tuples/sec | 891.94 tuples/sec | +0.2% | -9.0% |
   | bs=100 sw=10 sl=64 | MB/s | 0.495 MB/s | 0.494 MB/s | 0.544 MB/s | +0.2% | -9.1% |
   | bs=100 sw=10 sl=64 | p50 | 120,909 us | 121,146 us | 112,277 us | -0.2% | +7.7% |
   | bs=100 sw=10 sl=64 | p95 | 144,168 us | 159,888 us | 139,802 us | -9.8% | +3.1% |
   | bs=100 sw=10 sl=64 | p99 | 144,168 us | 159,888 us | 139,802 us | -9.8% | +3.1% |
   | bs=1000 sw=10 sl=64 | throughput | 943 tuples/sec | 961 tuples/sec | 1,041 tuples/sec | -1.9% | -9.4% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.575 MB/s | 0.586 MB/s | 0.635 MB/s | -1.9% | -9.5% |
   | bs=1000 sw=10 sl=64 | p50 | 1,065,812 us | 1,044,052 us | 972,714 us | +2.1% | +9.6% |
   | bs=1000 sw=10 sl=64 | p95 | 1,098,107 us | 1,097,550 us | 1,023,057 us | +0.1% | +7.3% |
   | bs=1000 sw=10 sl=64 | p99 | 1,098,107 us | 1,097,550 us | 1,023,057 us | +0.1% | +7.3% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,492.83,200,128000,406,0.248,23266.74,35078.03,35078.03
   1,100,10,64,20,2463.86,2000,1280000,812,0.495,120909.10,144168.15,144168.15
   2,1000,10,64,20,21216.27,20000,12800000,943,0.575,1065811.71,1098106.95,1098106.95
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(workflow-operator): pin ConnUtil URL composition without DriverManager [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #5728:
URL: https://github.com/apache/texera/pull/5728


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org