[GitHub] [cordova-ios] wmathurin opened a new pull request #1015: (iOS) Project changes to allow consuming cordova as submodule

[GitBox <gi...@apache.org>]

wmathurin opened a new pull request #1015:
URL: https://github.com/apache/cordova-ios/pull/1015


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   ### Motivation and Context
   If your application consumes cordova as a submodule and depends on the cordova dynamic framework, it will fail to run properly because the web view engine classes are not in the framework.
   As a result, CDVViewController fails to build the web view engine by reflection.
   ```obj-c
   self.webViewEngine = [[NSClassFromString(defaultWebViewEngineClass) alloc] initWithFrame:bounds];
   ```
   And the view controller is never unhidden.
   
   ### Description
   The change simply adds the cordova framework as a target for the web view engine classes.
   
   ### Testing
   In https://github.com/forcedotcom/salesforceMobileSDK-ios-hybrid, we consume cordova through a submodule.
   We have several sample apps as well as suites of tests. The change allowed the apps to run properly and the tests to pass.
   
   
   ### Checklist
   
   - [X] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] wmathurin commented on pull request #1015: (iOS) Project changes to allow consuming cordova as submodule

[GitBox <gi...@apache.org>]

wmathurin commented on pull request #1015:
URL: https://github.com/apache/cordova-ios/pull/1015#issuecomment-718902601


   The PR is not making them public but make them part of the framework target.
   
   The fallback is here: https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/Public/CDVViewController.m#L508
   
   Because the class is not in the framework, it fails to find the class at runtime.
   
   When you consume cordova through cocoapod, the class is available because we have
   ```
   cordova.source_files = 'CordovaLib/Classes/**/*.{h,m}', 'CordovaLib/Cordova/Cordova.h'
   ```
   in https://github.com/apache/cordova-ios/blob/master/Cordova.podspec#L41.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org