(commons-configuration) branch master updated: Make private class final

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-configuration.git


The following commit(s) were added to refs/heads/master by this push:
     new 47471743 Make private class final
47471743 is described below

commit 4747174391af5d7f6b492b90ffe4188b5b5b305a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 5 14:13:42 2023 -0500

    Make private class final
---
 .../apache/commons/configuration2/BaseHierarchicalConfiguration.java    | 2 +-
 .../java/org/apache/commons/configuration2/CombinedConfiguration.java   | 2 +-
 .../java/org/apache/commons/configuration2/SubsetConfiguration.java     | 2 +-
 .../configuration2/builder/combined/CombinedConfigurationBuilder.java   | 2 +-
 .../commons/configuration2/plist/XMLPropertyListConfiguration.java      | 2 +-
 .../apache/commons/configuration2/TestDynamicCombinedConfiguration.java | 2 +-
 .../org/apache/commons/configuration2/beanutils/TestBeanHelper.java     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/apache/commons/configuration2/BaseHierarchicalConfiguration.java b/src/main/java/org/apache/commons/configuration2/BaseHierarchicalConfiguration.java
index 2291b767..4392f1f4 100644
--- a/src/main/java/org/apache/commons/configuration2/BaseHierarchicalConfiguration.java
+++ b/src/main/java/org/apache/commons/configuration2/BaseHierarchicalConfiguration.java
@@ -640,7 +640,7 @@ public class BaseHierarchicalConfiguration extends AbstractHierarchicalConfigura
      * A specialized visitor implementation which constructs the root node of a configuration with all variables replaced by
      * their interpolated values.
      */
-    private class InterpolatedVisitor extends ConfigurationNodeVisitorAdapter<ImmutableNode> {
+    private final class InterpolatedVisitor extends ConfigurationNodeVisitorAdapter<ImmutableNode> {
         /** A stack for managing node builder instances. */
         private final List<ImmutableNode.Builder> builderStack;
 
diff --git a/src/main/java/org/apache/commons/configuration2/CombinedConfiguration.java b/src/main/java/org/apache/commons/configuration2/CombinedConfiguration.java
index eebfff5e..f11e5a76 100644
--- a/src/main/java/org/apache/commons/configuration2/CombinedConfiguration.java
+++ b/src/main/java/org/apache/commons/configuration2/CombinedConfiguration.java
@@ -779,7 +779,7 @@ public class CombinedConfiguration extends BaseHierarchicalConfiguration impleme
     /**
      * An internal helper class for storing information about contained configurations.
      */
-    private class ConfigData {
+    private final class ConfigData {
         /** Stores a reference to the configuration. */
         private final Configuration configuration;
 
diff --git a/src/main/java/org/apache/commons/configuration2/SubsetConfiguration.java b/src/main/java/org/apache/commons/configuration2/SubsetConfiguration.java
index 16be2b4e..9db6d769 100644
--- a/src/main/java/org/apache/commons/configuration2/SubsetConfiguration.java
+++ b/src/main/java/org/apache/commons/configuration2/SubsetConfiguration.java
@@ -235,7 +235,7 @@ public class SubsetConfiguration extends AbstractConfiguration {
      * A specialized iterator to be returned by the {@code getKeys()} methods. This implementation wraps an iterator from
      * the parent configuration. The keys returned by this iterator are correspondingly transformed.
      */
-    private class SubsetIterator implements Iterator<String> {
+    private final class SubsetIterator implements Iterator<String> {
         /** Stores the wrapped iterator. */
         private final Iterator<String> parentIterator;
 
diff --git a/src/main/java/org/apache/commons/configuration2/builder/combined/CombinedConfigurationBuilder.java b/src/main/java/org/apache/commons/configuration2/builder/combined/CombinedConfigurationBuilder.java
index dc625929..68c47262 100644
--- a/src/main/java/org/apache/commons/configuration2/builder/combined/CombinedConfigurationBuilder.java
+++ b/src/main/java/org/apache/commons/configuration2/builder/combined/CombinedConfigurationBuilder.java
@@ -1073,7 +1073,7 @@ public class CombinedConfigurationBuilder extends BasicConfigurationBuilder<Comb
     /**
      * A data class for storing information about all configuration sources defined for a combined builder.
      */
-    private class ConfigurationSourceData {
+    private final class ConfigurationSourceData {
         /** A list with data for all builders for override configurations. */
         private final List<ConfigurationDeclaration> overrideDeclarations;
 
diff --git a/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java b/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java
index af419123..cc1711a5 100644
--- a/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java
+++ b/src/main/java/org/apache/commons/configuration2/plist/XMLPropertyListConfiguration.java
@@ -372,7 +372,7 @@ public class XMLPropertyListConfiguration extends BaseHierarchicalConfiguration
     /**
      * SAX Handler to build the configuration nodes while the document is being parsed.
      */
-    private class XMLPropertyListHandler extends DefaultHandler {
+    private final class XMLPropertyListHandler extends DefaultHandler {
         /** The buffer containing the text node being read */
         private final StringBuilder buffer = new StringBuilder();
 
diff --git a/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java b/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
index d24ef9c0..f4b36668 100644
--- a/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
+++ b/src/test/java/org/apache/commons/configuration2/TestDynamicCombinedConfiguration.java
@@ -54,7 +54,7 @@ import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
 public class TestDynamicCombinedConfiguration {
-    private class ReaderThread extends Thread {
+    private final class ReaderThread extends Thread {
         private volatile boolean running = true;
         private volatile boolean failed;
         private final CombinedConfigurationBuilder builder;
diff --git a/src/test/java/org/apache/commons/configuration2/beanutils/TestBeanHelper.java b/src/test/java/org/apache/commons/configuration2/beanutils/TestBeanHelper.java
index ce6f1782..7e6e20bb 100644
--- a/src/test/java/org/apache/commons/configuration2/beanutils/TestBeanHelper.java
+++ b/src/test/java/org/apache/commons/configuration2/beanutils/TestBeanHelper.java
@@ -47,7 +47,7 @@ public class TestBeanHelper {
      * An implementation of the BeanFactory interface used for testing. This implementation is really simple: If the
      * BeanCreationTestBean class is provided, a new instance will be created. Otherwise an exception is thrown.
      */
-    private class TestBeanFactory implements BeanFactory {
+    private final class TestBeanFactory implements BeanFactory {
         Object parameter;
 
         boolean supportsDefaultClass;