You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 07:20:48 UTC

[GitHub] [airflow] ephraimbuddy commented on issue #28756: All Airflow Configurations set via Environment Variable are masked when `expose_config` is set as `non-sensitive-only`

ephraimbuddy commented on issue #28756:
URL: https://github.com/apache/airflow/issues/28756#issuecomment-1373246327

   I think we should hide this in `_include_envs` so it's same as `_include_cmds` & `_include_secrets`:
   
   ```diff
   diff --git a/airflow/configuration.py b/airflow/configuration.py
   index 41778fe374..df393da6e6 100644
   --- a/airflow/configuration.py
   +++ b/airflow/configuration.py
   @@ -1149,7 +1149,8 @@ class AirflowConfigParser(ConfigParser):
                if not display_sensitive and env_var != self._env_var_name("core", "unit_test_mode"):
                    # Don't hide cmd/secret values here
                    if not env_var.lower().endswith("cmd") and not env_var.lower().endswith("secret"):
   -                    opt = "< hidden >"
   +                    if (section, key) in self.sensitive_config_values:
   +                        opt = "< hidden >"
    
                elif raw:
                    opt = opt.replace("%", "%%")
   (END)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org