[jira] [Commented] (MRESOLVER-347) Better connection pool configuration (reuse, max TTL, maxPerRoute)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRESOLVER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707012#comment-17707012 ] 

ASF GitHub Bot commented on MRESOLVER-347:
------------------------------------------

slawekjaranowski commented on code in PR #274:
URL: https://github.com/apache/maven-resolver/pull/274#discussion_r1153710418


##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -159,6 +159,51 @@ public final class ConfigurationProperties {
      */
     public static final boolean DEFAULT_HTTP_PREEMPTIVE_AUTH = false;
 
+    /**
+     * Should HTTP client reuse connections (in other words, pool connections) or not?
+     *
+     * @see #DEFAULT_HTTP_REUSE_CONNECTIONS
+     * @since 1.9.8
+     */
+    public static final String HTTP_REUSE_CONNECTIONS = PREFIX_CONNECTOR + "http.reuseConnections";
+
+    /**
+     * The default value to use if {@link #HTTP_REUSE_CONNECTIONS} isn't set (true).
+     *
+     * @since 1.9.8
+     */
+    public static final boolean DEFAULT_HTTP_REUSE_CONNECTIONS = true;
+
+    /**
+     * Time to live in seconds for an HTTP connection, after that time, the connection will be dropped.
+     *
+     * @see #DEFAULT_HTTP_CONNECTION_MAX_TTL
+     * @since 1.9.8
+     */
+    public static final String HTTP_CONNECTION_MAX_TTL = PREFIX_CONNECTOR + "http.connectionMaxTtl";
+
+    /**
+     * The default value to use if {@link #HTTP_CONNECTION_MAX_TTL} isn't set (600 seconds).
+     *
+     * @since 1.9.8
+     */
+    public static final int DEFAULT_HTTP_CONNECTION_MAX_TTL = 600;

Review Comment:
   I still think that 300 will be better - will be the same as is in Wagon - I don't see reason to change it.
   Even more - users on system like Azure will must set additional configuration parameter - now it is not needed.





> Better connection pool configuration (reuse, max TTL, maxPerRoute)
> ------------------------------------------------------------------
>
>                 Key: MRESOLVER-347
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-347
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.8
>
>
> Add more pool related configuration:
> * connection reuse
> * connection max TTL
> * max connection per route



--
This message was sent by Atlassian Jira
(v8.20.10#820010)