Re: [PR] fix: Gamma users shouldn't be able to create roles [superset]

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #29687:
URL: https://github.com/apache/superset/pull/29687#discussion_r1707420370


##########
superset/config.py:
##########
@@ -320,6 +320,8 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
 # ex: http://localhost:8080/swagger/v1
 FAB_API_SWAGGER_UI = True
 
+FAB_ADD_SECURITY_API = True

Review Comment:
   @dpgaspar did we make and update in flask app builder to make this default True? When I recently pulled these were getting `KeyError: FAB_ADD_SECURITY_API not found` Also I saw that flask app builder has this default True so to allow these test to run I just made this value consistent with what I saw upstream.
   
   Can you verify that this is what's happening?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org