[GitHub] [hive] vihangk1 commented on a change in pull request #1355: send tableId to get_partition APIs

[GitBox <gi...@apache.org>]

vihangk1 commented on a change in pull request #1355:
URL: https://github.com/apache/hive/pull/1355#discussion_r464689406



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -3258,8 +3260,19 @@ public Partition createPartition(Table tbl, Map<String, String> partSpec) throws
 
   public org.apache.hadoop.hive.metastore.api.Partition getPartition(String dbName, String tableName,

Review comment:
       The only place where this method is called currently in the code is in AlterTableAddPartitionOperation.java. Instead of introducing an addtional RPC, perhaps a better way is to send the Table (ql.metadata.Table) object in this method so that we can pass the tableId directly without getting the table from metastore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org