You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/26 08:53:21 UTC

[GitHub] [iotdb] xinzhongtianxia commented on a diff in pull request #5667: [IOTDB-2803]fix some UT code smell and refine plannode serialize

xinzhongtianxia commented on code in PR #5667:
URL: https://github.com/apache/iotdb/pull/5667#discussion_r858459167


##########
server/src/main/java/org/apache/iotdb/db/mpp/sql/planner/plan/node/metedata/write/AlterTimeSeriesNode.java:
##########
@@ -263,8 +213,49 @@ public <R, C> R accept(PlanVisitor<R, C> visitor, C schemaRegion) {
 
   @Override
   protected void serializeAttributes(ByteBuffer byteBuffer) {
-    throw new NotImplementedException(
-        "serializeAttributes of AlterTimeSeriesNode is not implemented");
+    byteBuffer.putShort((short) PlanNodeType.ALTER_TIME_SERIES.ordinal());

Review Comment:
   may be it is better to use `PlanNodeType#serialize`,   and why use `ordinal()` other than `nodeType`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org