You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/10/17 09:36:06 UTC
[GitHub] [httpcomponents-client] arturobernalg commented on a change in pull request #314: Minor fix.
arturobernalg commented on a change in pull request #314:
URL: https://github.com/apache/httpcomponents-client/pull/314#discussion_r730385053
##########
File path: httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ResponseCachingPolicy.java
##########
@@ -302,7 +302,7 @@ private boolean expiresHeaderLessOrEqualToDateHeaderAndNoCacheControl(final Http
private boolean from1_0Origin(final HttpResponse response) {
final Iterator<HeaderElement> it = MessageSupport.iterate(response, HeaderConstants.VIA);
- while (it.hasNext()) {
+ if (it.hasNext()) {
Review comment:
because it doesn't iterate. and in the best case it returns the protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org