You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/24 12:02:33 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3603: MINOR: improve docstrings on SessionContext
alamb opened a new pull request, #3603:
URL: https://github.com/apache/arrow-datafusion/pull/3603
# Which issue does this PR close?
N/A
# Rationale for this change
I started making some minor changes I noticed while reviewing https://github.com/apache/arrow-datafusion/pull/3600 (see https://github.com/apache/arrow-datafusion/pull/3600#discussion_r979231669)
# What changes are included in this PR?
Improve docstrings, fix some links
# Are there any user-facing changes?
Better API docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3603: MINOR: improve docstrings on SessionContext
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3603:
URL: https://github.com/apache/arrow-datafusion/pull/3603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3603: MINOR: improve docstrings on SessionContext
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3603:
URL: https://github.com/apache/arrow-datafusion/pull/3603#discussion_r979233779
##########
datafusion/core/src/physical_plan/aggregates/mod.rs:
##########
@@ -90,8 +90,8 @@ pub struct PhysicalGroupBy {
null_expr: Vec<(Arc<dyn PhysicalExpr>, String)>,
/// Null mask for each group in this grouping set. Each group is
/// composed of either one of the group expressions in expr or a null
- /// expression in null_expr. If groups[i][j] is true, then the the
- /// j-th expression in the i-th group is NULL, otherwise it is expr[j].
+ /// expression in null_expr. If `groups[i][j]` is true, then the the
Review Comment:
this is a driveby cleanup -- `rustdoc` was complaining that `i` and `j` were not valid links 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3603: MINOR: improve docstrings on SessionContext
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3603:
URL: https://github.com/apache/arrow-datafusion/pull/3603#issuecomment-1257179541
Benchmark runs are scheduled for baseline = 696a0b5146842978962cc7e3b94a6a993e2ad460 and contender = ebb28f54049813f1990a44ca75a8867175633180. ebb28f54049813f1990a44ca75a8867175633180 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/74fcfe896b5e49d892ababb1099fdfe9...a4ee5941e6a14e1a8e7359d40a631f8c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d39111fa30f5437994b40e9feae4a4c2...33b27c34149a41f883fe5297a697aa19/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/94cae110c3bd44edb59bfc42f4c94a82...c64f5aa7916e4db8a2afc22811a9c4c6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/3cf3eadf10f3489a931ba15c2253b61e...ed9c6b9da7544ac08ff3a53986e696fc/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org