You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2024/08/27 16:57:30 UTC
[PR] cleanup scan session when batch scanner closed [accumulo]
keith-turner opened a new pull request, #4841:
URL: https://github.com/apache/accumulo/pull/4841
When not all data is read from a scanner it can leave server side scan sessions open. When the scanner object is closed on the client side it should close these server side scan sessions. The batch scanner was not doing this. Updated the batch scanner to close sever side sessions. Added test for the scanner and batch scanner to ensure sessions are cleaned up. Improved an existing test related to session timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup scan session when batch scanner closed [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #4841:
URL: https://github.com/apache/accumulo/pull/4841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup scan session when batch scanner closed [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4841:
URL: https://github.com/apache/accumulo/pull/4841#discussion_r1733531003
##########
test/src/main/java/org/apache/accumulo/test/functional/ScannerIT.java:
##########
@@ -113,4 +117,82 @@ public void testScannerReadaheadConfiguration() throws Exception {
}
}
}
+
+ @Test
+ public void testSessionCleanup() throws Exception {
+ String tableName = getUniqueNames(1)[0];
+ final String table = getUniqueNames(1)[0];
Review Comment:
duplicate variable? Can this be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cleanup scan session when batch scanner closed [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4841:
URL: https://github.com/apache/accumulo/pull/4841#discussion_r1733541034
##########
test/src/main/java/org/apache/accumulo/test/functional/ScannerIT.java:
##########
@@ -113,4 +117,82 @@ public void testScannerReadaheadConfiguration() throws Exception {
}
}
}
+
+ @Test
+ public void testSessionCleanup() throws Exception {
+ String tableName = getUniqueNames(1)[0];
+ final String table = getUniqueNames(1)[0];
Review Comment:
ah some copy paste shenanigans, cleaned that up in 5c3b851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org