You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/09 00:54:00 UTC

[GitHub] lovelle opened a new pull request #3337: Bug fixes/Improvement for notify pending receive method

lovelle opened a new pull request #3337: Bug fixes/Improvement for notify pending receive method
URL: https://github.com/apache/pulsar/pull/3337
 
 
   Bug fixes/Improvement for notify pending receive method
   
   ### Motivation
   
   Prevent 2 bugs and refactoring for method [notifyPendingReceivedCallback()](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L912) 
   
   ### Modifications
   
     - Bugfix interceptor missed event when prefetch messages is disabled by
       consumer `ReceiverQueueSize == 0`.
     - Bugfix when message is null and no exception is present. Previously to this
       commit testing if message was null was made by `checkNotNull()` method leaving
       consumed future without completion resulting in a hanged future.
     - Refactor to favour simplicity and readability for control flow.
     - Add unit tests exploiting bug fixes.
   
   ### Result
   
   Bug fixes and more maintainable code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services