You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2012/12/03 08:30:23 UTC

svn commit: r1416364 - /ofbiz/trunk/themes/flatgrey/build.xml

Author: jleroux
Date: Mon Dec  3 07:30:22 2012
New Revision: 1416364

URL: http://svn.apache.org/viewvc?rev=1416364&view=rev
Log:
This can't work for now because in r1416358 I removed the yuicompressor from OFBiz

Modified:
    ofbiz/trunk/themes/flatgrey/build.xml

Modified: ofbiz/trunk/themes/flatgrey/build.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/build.xml?rev=1416364&r1=1416363&r2=1416364&view=diff
==============================================================================
--- ofbiz/trunk/themes/flatgrey/build.xml (original)
+++ ofbiz/trunk/themes/flatgrey/build.xml Mon Dec  3 07:30:22 2012
@@ -37,12 +37,13 @@ under the License.
     </target>
 
     <target name="build" depends="">
-        <echo message="[build] ========== Building Flat Grey Theme ==========" />
+        <!--  commented out because the yuicompressor has been (temporarily?) removed. It was conflicting with Birt... --> 
+        <!-- echo message="[build] ========== Building Flat Grey Theme ==========" />
         <yuicompressor inFile="webapp/flatgrey/js/application.js" outFile="webapp/flatgrey/js/application-min.js" />
         <yuicompressor inFile="webapp/flatgrey/javascript.css" outFile="webapp/flatgrey/javascript-min.css" />
         <yuicompressor inFile="webapp/flatgrey/maincss.css" outFile="webapp/flatgrey/maincss-min.css" />
         <yuicompressor inFile="webapp/flatgrey/mainrtl.css" outFile="webapp/flatgrey/mainrtl-min.css" />
-        <echo message="[build] ========== Done Building Flat Grey Theme ==========" />
+        <echo message="[build] ========== Done Building Flat Grey Theme ==========" /-->
     </target>
 
 </project>



Re: svn commit: r1416364 - /ofbiz/trunk/themes/flatgrey/build.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Done with https://issues.apache.org/jira/browse/OFBIZ-5096

Jacques

Jacques Le Roux wrote:
> Thanks for review Adrian, I will do...
> 
> Jacques
> 
> From: "Adrian Crum" <ad...@sandglass-software.com>
>> The theme seed data must be changed after this commit.
>> 
>> -Adrian
>> 
>> On 12/3/2012 7:30 AM, jleroux@apache.org wrote:
>>> Author: jleroux
>>> Date: Mon Dec  3 07:30:22 2012
>>> New Revision: 1416364
>>> 
>>> URL: http://svn.apache.org/viewvc?rev=1416364&view=rev
>>> Log:
>>> This can't work for now because in r1416358 I removed the yuicompressor from OFBiz
>>> 
>>> Modified:
>>>      ofbiz/trunk/themes/flatgrey/build.xml
>>> 
>>> Modified: ofbiz/trunk/themes/flatgrey/build.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/build.xml?rev=1416364&r1=1416363&r2=1416364&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/themes/flatgrey/build.xml (original)
>>> +++ ofbiz/trunk/themes/flatgrey/build.xml Mon Dec  3 07:30:22 2012
>>> @@ -37,12 +37,13 @@ under the License.
>>>       </target>
>>> 
>>>       <target name="build" depends="">
>>> -        <echo message="[build] ========== Building Flat Grey Theme ==========" />
>>> +        <!--  commented out because the yuicompressor has been (temporarily?) removed. It was conflicting with Birt... -->
>>> +        <!-- echo message="[build] ========== Building Flat Grey Theme ==========" />
>>>           <yuicompressor inFile="webapp/flatgrey/js/application.js" outFile="webapp/flatgrey/js/application-min.js" />
>>>           <yuicompressor inFile="webapp/flatgrey/javascript.css" outFile="webapp/flatgrey/javascript-min.css" />
>>>           <yuicompressor inFile="webapp/flatgrey/maincss.css" outFile="webapp/flatgrey/maincss-min.css" />
>>>           <yuicompressor inFile="webapp/flatgrey/mainrtl.css" outFile="webapp/flatgrey/mainrtl-min.css" />
>>> -        <echo message="[build] ========== Done Building Flat Grey Theme ==========" />
>>> +        <echo message="[build] ========== Done Building Flat Grey Theme ==========" /-->
>>>       </target>
>>> 
>>>   </project>

Re: svn commit: r1416364 - /ofbiz/trunk/themes/flatgrey/build.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks for review Adrian, I will do...

Jacques

From: "Adrian Crum" <ad...@sandglass-software.com>
> The theme seed data must be changed after this commit.
> 
> -Adrian
> 
> On 12/3/2012 7:30 AM, jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Mon Dec  3 07:30:22 2012
>> New Revision: 1416364
>>
>> URL: http://svn.apache.org/viewvc?rev=1416364&view=rev
>> Log:
>> This can't work for now because in r1416358 I removed the yuicompressor from OFBiz
>>
>> Modified:
>>      ofbiz/trunk/themes/flatgrey/build.xml
>>
>> Modified: ofbiz/trunk/themes/flatgrey/build.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/build.xml?rev=1416364&r1=1416363&r2=1416364&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/themes/flatgrey/build.xml (original)
>> +++ ofbiz/trunk/themes/flatgrey/build.xml Mon Dec  3 07:30:22 2012
>> @@ -37,12 +37,13 @@ under the License.
>>       </target>
>>   
>>       <target name="build" depends="">
>> -        <echo message="[build] ========== Building Flat Grey Theme ==========" />
>> +        <!--  commented out because the yuicompressor has been (temporarily?) removed. It was conflicting with Birt... -->
>> +        <!-- echo message="[build] ========== Building Flat Grey Theme ==========" />
>>           <yuicompressor inFile="webapp/flatgrey/js/application.js" outFile="webapp/flatgrey/js/application-min.js" />
>>           <yuicompressor inFile="webapp/flatgrey/javascript.css" outFile="webapp/flatgrey/javascript-min.css" />
>>           <yuicompressor inFile="webapp/flatgrey/maincss.css" outFile="webapp/flatgrey/maincss-min.css" />
>>           <yuicompressor inFile="webapp/flatgrey/mainrtl.css" outFile="webapp/flatgrey/mainrtl-min.css" />
>> -        <echo message="[build] ========== Done Building Flat Grey Theme ==========" />
>> +        <echo message="[build] ========== Done Building Flat Grey Theme ==========" /-->
>>       </target>
>>   
>>   </project>
>>
>>
>

Re: svn commit: r1416364 - /ofbiz/trunk/themes/flatgrey/build.xml

Posted by Adrian Crum <ad...@sandglass-software.com>.
The theme seed data must be changed after this commit.

-Adrian

On 12/3/2012 7:30 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Mon Dec  3 07:30:22 2012
> New Revision: 1416364
>
> URL: http://svn.apache.org/viewvc?rev=1416364&view=rev
> Log:
> This can't work for now because in r1416358 I removed the yuicompressor from OFBiz
>
> Modified:
>      ofbiz/trunk/themes/flatgrey/build.xml
>
> Modified: ofbiz/trunk/themes/flatgrey/build.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/themes/flatgrey/build.xml?rev=1416364&r1=1416363&r2=1416364&view=diff
> ==============================================================================
> --- ofbiz/trunk/themes/flatgrey/build.xml (original)
> +++ ofbiz/trunk/themes/flatgrey/build.xml Mon Dec  3 07:30:22 2012
> @@ -37,12 +37,13 @@ under the License.
>       </target>
>   
>       <target name="build" depends="">
> -        <echo message="[build] ========== Building Flat Grey Theme ==========" />
> +        <!--  commented out because the yuicompressor has been (temporarily?) removed. It was conflicting with Birt... -->
> +        <!-- echo message="[build] ========== Building Flat Grey Theme ==========" />
>           <yuicompressor inFile="webapp/flatgrey/js/application.js" outFile="webapp/flatgrey/js/application-min.js" />
>           <yuicompressor inFile="webapp/flatgrey/javascript.css" outFile="webapp/flatgrey/javascript-min.css" />
>           <yuicompressor inFile="webapp/flatgrey/maincss.css" outFile="webapp/flatgrey/maincss-min.css" />
>           <yuicompressor inFile="webapp/flatgrey/mainrtl.css" outFile="webapp/flatgrey/mainrtl-min.css" />
> -        <echo message="[build] ========== Done Building Flat Grey Theme ==========" />
> +        <echo message="[build] ========== Done Building Flat Grey Theme ==========" /-->
>       </target>
>   
>   </project>
>
>