[GitHub] [mynewt-core] vrahane commented on a change in pull request #2052: FCB Rotate Notification

[GitBox <gi...@apache.org>]

vrahane commented on a change in pull request #2052: FCB Rotate Notification
URL: https://github.com/apache/mynewt-core/pull/2052#discussion_r336215447
 
 

 ##########
 File path: sys/log/full/src/log.c
 ##########
 @@ -916,6 +921,23 @@ log_walk_body(struct log *log, log_walk_body_func_t walk_body_func,
     return rc;
 }
 
+int
+log_walk_body_section(struct log *log, log_walk_body_func_t walk_body_func,
+              struct log_offset *log_offset)
+{
+    struct log_walk_body_arg lwba = {
+        .fn = walk_body_func,
+        .arg = log_offset->lo_arg,
+    };
+    int rc;
+
+    log_offset->lo_arg = &lwba;
+    rc = log->l_log->log_walk_sector(log, log_walk_body_fn, log_offset);
 
 Review comment:
   I agree with the comment here, I also feel that there might be cases for log mediums that might not have sectors, should we renaming it to something like `log_walk_block` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services