[GitHub] [incubator-mxnet] connorgoggins commented on a change in pull request #17456: Implement remaining nn_basic ops in opperf

[GitBox <gi...@apache.org>]

connorgoggins commented on a change in pull request #17456: Implement remaining nn_basic ops in opperf
URL: https://github.com/apache/incubator-mxnet/pull/17456#discussion_r376044801
 
 

 ##########
 File path: benchmark/opperf/utils/op_registry_utils.py
 ##########
 @@ -122,12 +122,21 @@ def prepare_op_inputs(op, arg_params):
     # 3d tensor is needed by following ops
     ops_3d = ['CTCLoss', 'ctc_loss']
 
+    custom_data = ['SpatialTransformer', 'col2im', 'RNN', 'GroupNorm', 'Dropout', 'FullyConnected', 'SoftmaxOutput', 'LinearRegressionOutput', 'BatchNorm',
+                            'LogisticRegressionOutput', 'MAERegressionOutput', 'SVMOutput', 'L2Normalization',
+                            'LayerNorm', 'InstanceNorm', 'Embedding', 'Correlation', 'im2col', 'LRN']
+
+    # Args for NN basic ops which vary across different ops
+    ops_nn_variable_args = ['weight', 'label', 'mode', 'gamma', 'beta', 'kernel', 'stride', 'dilate', 'pad', 'p', 'axis', 'loc', "moving_mean","moving_var"]
 
 Review comment:
   Good point, dropping.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services