You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "apeskov (via GitHub)" <gi...@apache.org> on 2023/04/27 12:53:55 UTC

[GitHub] [tvm] apeskov opened a new pull request, #14732: [MetaSchedule] Skip custom_rule in case of None

apeskov opened a new pull request, #14732:
URL: https://github.com/apache/tvm/pull/14732

   Custom rule mechanics allows to have "schedule_rule" attribute equals "None". This value will be ignored by `ApplyCustomRuleNode`. But also this block will be ignore by all other rules. It happens because of improper check in `PostOrderApplyNode`.
   
   This patch allows to use regular rules in case of `schedule_rule=="None"`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #14732: [MetaSchedule] Skip custom_rule in case of None

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14732:
URL: https://github.com/apache/tvm/pull/14732#issuecomment-1525645712

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @ibsidorenko <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Hzfengsy commented on pull request #14732: [MetaSchedule] Skip custom_rule in case of None

Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #14732:
URL: https://github.com/apache/tvm/pull/14732#issuecomment-1527026549

   cc @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] apeskov commented on pull request #14732: [MetaSchedule] Skip custom_rule in case of None

Posted by "apeskov (via GitHub)" <gi...@apache.org>.
apeskov commented on PR #14732:
URL: https://github.com/apache/tvm/pull/14732#issuecomment-1527979933

   @junrushao could you please take a look. In your previous patch [#13195](https://github.com/apache/tvm/pull/13195) with refactoring of custom rules you already had a [discussion](https://github.com/apache/tvm/pull/13195/files#r1018952166) with @masahi about auto tensorization issue. 
   
   But there is an another aspect. In case of `schedule_rule == "None"`, ApplyCustomRule and `sch->Unannotate` will not be called. So block will not be processed by any schedule rule never. I'm not sure if it was in the design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MetaSchedule] Skip custom_rule in case of None [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed pull request #14732: [MetaSchedule] Skip custom_rule in case of None
URL: https://github.com/apache/tvm/pull/14732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #14732: [MetaSchedule] Skip custom_rule in case of None

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14732:
URL: https://github.com/apache/tvm/pull/14732#issuecomment-1528097391

   I vaguely recall that there is a reason that we use `custom_rule: None`, which means we wanted to design space generator to intentionally skip a block. My assumption was that if we have a good usecase if we want the generator not to skip, then perhaps we could unannotate the block first - but I'm happy to change my mind if the situation above has been taken good consideration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org