[lucene] 02/18: SOLR-13300: DistributedFacetExistsSmallTest should not attempt to compare results of a query that is known to differ in behavior in distributed mode

[dw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch branch_8_0
in repository https://gitbox.apache.org/repos/asf/lucene.git

commit 7630f7906971d8ac9ae0c2cedd9b6e16364a501e
Author: Chris Hostetter <ho...@apache.org>
AuthorDate: Mon Mar 11 10:02:46 2019 -0700

    SOLR-13300: DistributedFacetExistsSmallTest should not attempt to compare results of a query that is known to differ in behavior in distributed mode
    
    (cherry picked from commit 7eb728a611a5cad82e44bd662294d682353a2ccb)
---
 .../handler/component/DistributedFacetExistsSmallTest.java     | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java b/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java
index 58c5a2e..0c381e9 100644
--- a/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmallTest.java
@@ -125,7 +125,9 @@ public class DistributedFacetExistsSmallTest extends BaseDistributedSearchTestCa
       params.add("facet.prefix", prefixes[rand.nextInt(prefixes.length)]);
     }
 
-    if (rand.nextInt(100) < 20) {
+    // don't bother trying to to test facet.missing=true + facet.limit=0
+    // distrib & non-distrib are known to behave differently in this 
+    if (rand.nextInt(100) < 20 && 0 < params.getInt("facet.limit", 100)) {
       params.add("facet.missing", "true");
     }
     
@@ -133,13 +135,7 @@ public class DistributedFacetExistsSmallTest extends BaseDistributedSearchTestCa
       params.add("facet.mincount", rand.nextBoolean() ? "0": "1" );
     }
     
-    final boolean shardRespondsWithMissingEvenLimitIsZero = 
-          params.getBool("facet.missing", false) && params.getInt("facet.limit", 100)==0;
-
     query(params);
-    if (shardRespondsWithMissingEvenLimitIsZero ) {
-      handle.remove(null);
-    }
   }
   
   private void checkInvalidMincount() throws SolrServerException, IOException {