[GitHub] rafaelweingartner commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #3077: ipv6: Calculate IPv6 address instead of fetching one from a pool
URL: https://github.com/apache/cloudstack/pull/3077#discussion_r247311643
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/Ipv6AddressManagerImpl.java
 ##########
 @@ -260,4 +173,37 @@ protected boolean isIp6Taken(Network network, String requestedIpv6) {
         return ip6Vo != null || nicSecondaryIpVO != null;
     }
 
+    @Override
+    public void setNicIp6Address(final NicProfile nic, final DataCenter dc, final Network network) {
 
 Review comment:
   So, here you are defining an IPv6 based on a NIC mac address. I wonder, can a NIC have more than one IPv6 address? I know the generic answer is yes, but I am refereeing to the design of IPv6 in ACS.  Was it designed to allow more than one IPv6 per NIC? If so, how would we define these other IPv6s?
   
   I ask that because there is a bug right now in `AddIpToVmNicCmd` API method, and it has to do with the assignment of secondary IPs to NICs. The user is able to ask for extra IPs to a NIC. Then, if the user does not inform the desired IP, ACS will generate one. For IPv4, it is quite clear how to fix the bug, but for IPv6… and according to what we have here, I am not sure how we would do it. Do you have any suggestion?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services