You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rolando <gi...@git.apache.org> on 2017/02/16 22:44:20 UTC
[GitHub] spark pull request #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'top...
GitHub user rolando opened a pull request:
https://github.com/apache/spark/pull/16967
[MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
## What changes were proposed in this pull request?
Fix typo in docstring.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rolando-contrib/spark pyspark-doc-typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16967.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16967
----
commit fe1ff4f5e1df5eae538522f8e62f1ff30e6a5853
Author: Rolando Espinoza <rn...@gmail.com>
Date: 2017-02-16T22:31:23Z
[MINOR][DOCS] Fix typo 'top' -> 'topic'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
Posted by rolando <gi...@git.apache.org>.
Github user rolando commented on the issue:
https://github.com/apache/spark/pull/16967
I've (rip)grep'ed over all `.py` and `.md` files in the repository searching for ` topi? ` (case insensitive regex) and haven't seen other case of this typo (writing `top` instead of `topic`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16967
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/16967
Sure, it's worth a search for similar instances because sometimes typos spread via copy and paste. Could you make a pass over related code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16967
**[Test build #3577 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3577/testReport)** for PR 16967 at commit [`fe1ff4f`](https://github.com/apache/spark/commit/fe1ff4f5e1df5eae538522f8e62f1ff30e6a5853).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16967
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'top...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16967
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16967: [MINOR][PYTHON] Fix typo docstring: 'top' -> 'topic'
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16967
**[Test build #3577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3577/testReport)** for PR 16967 at commit [`fe1ff4f`](https://github.com/apache/spark/commit/fe1ff4f5e1df5eae538522f8e62f1ff30e6a5853).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org