You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/08/29 22:25:58 UTC
[kudu-CR] KUDU-2560: exported thirdparty library variants should use exported deps
Hello Alexey Serbin, Dan Burkert, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11354
to review the following change.
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps
......................................................................
KUDU-2560: exported thirdparty library variants should use exported deps
This addresses a longstanding bug in ADD_THIRDPARTY_LIB that caused
"exported" thirdparty library targets to express their own thirdparty
dependencies in terms of regular (i.e. non-exported) targets.
The first time this mattered was in commit d55df3c6e, where libunwind was
added as a dependency of glog. This caused the exported client library, by
virtue of its glog dependency, to depend on 'unwind' (shared object) instead
of on 'unwind_exported' (static archive). In most systems the linker elided
that dependency because it was unnecessary, but it is preserved by the
linker in devtoolset3. That causes client_examples-test to fail if the
system doesn't have libunwind installed.
While I was there I removed some usages of DEPS that were not actually used.
Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
---
M CMakeLists.txt
M cmake_modules/FindPmem.cmake
2 files changed, 8 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/11354/1
--
To view, visit http://gerrit.cloudera.org:8080/11354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Gerrit-Change-Number: 11354
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] KUDU-2560: exported thirdparty library variants should use exported deps
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11354 )
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps
......................................................................
Patch Set 2:
Thanks for solving this!
--
To view, visit http://gerrit.cloudera.org:8080/11354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Gerrit-Change-Number: 11354
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 30 Aug 2018 01:40:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2560: exported thirdparty library variants should use exported deps
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11354 )
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Gerrit-Change-Number: 11354
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 29 Aug 2018 22:28:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2560: exported thirdparty library variants should use exported deps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11354 )
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps
......................................................................
KUDU-2560: exported thirdparty library variants should use exported deps
This addresses a longstanding bug in ADD_THIRDPARTY_LIB that caused
"exported" thirdparty library targets to express their own thirdparty
dependencies in terms of regular (i.e. non-exported) targets.
The first time this mattered was in commit d55df3c6e, where libunwind was
added as a dependency of glog. This caused the exported client library, by
virtue of its glog dependency, to depend on 'unwind' (shared object) instead
of on 'unwind_exported' (static archive). In most systems the linker elided
that dependency because it was unnecessary, but it is preserved by the
linker in devtoolset3. That causes client_examples-test to fail if the
system doesn't have libunwind installed.
While I was there I removed some usages of DEPS that were not actually used.
Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Reviewed-on: http://gerrit.cloudera.org:8080/11354
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
M cmake_modules/FindPmem.cmake
2 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Dan Burkert: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Gerrit-Change-Number: 11354
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2560: exported thirdparty library variants should use exported deps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11354 )
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Gerrit-Change-Number: 11354
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 30 Aug 2018 01:16:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2560: exported thirdparty library variants should use exported deps
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11354 )
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps
......................................................................
Patch Set 1: Code-Review+1
Reading the commit msg, this change makes sense, but I'll defer to Alexey. I haven't written enough CMake to know if there are any gotchas to keep in mind.
--
To view, visit http://gerrit.cloudera.org:8080/11354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1
Gerrit-Change-Number: 11354
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 29 Aug 2018 22:48:15 +0000
Gerrit-HasComments: No