You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2018/12/12 14:32:27 UTC

[GitHub] justinleet opened a new pull request #1299: METRON-1929: Build GET_ASN Stellar function

justinleet opened a new pull request #1299: METRON-1929: Build GET_ASN Stellar function
URL: https://github.com/apache/metron/pull/1299
 
 
   ## Contributor Comments
   This PR adds a Stellar function for getting Autonymous System Number info given an IP address.
   
   It also refactors the existing Geo database stuff in order to reuse a good amount of that.  The geo_enrichment_load.sh is also updated to handle both files.  A couple points for discussion here
   
   - Do we want to rename this file and tell users they'll have to use the new version? I don't know how widely used it is.
   - Existing users would not be pulling the ASN database, and for offline installs the script would currently require the ASN database.
   
   I'm inclined to update the Upgrading.md and just telling users to load the ASN database into HDFS, and update any scripts using geo_enrichment_load.sh to use the new thing, along with updating offline installs to also provide the ASN database.  New, online installs will pull down both DBs and load them (e.g. full dev).
   
   While implementing this I also discovered that the location of the MaxMind DB online was changed (including the format itself from .gz to tar.gz).  Given that their ASN db needed this, I set things up to support .tar.gz, .gz, and just the bare mmdb file.  There's one question that arises out of this.
   - Do we update the Geo DB default URL to point to the updated DB?  I'm strongly inclined to do so, but held off pending this PR being discussed.  Users should just have to update to the latest from the MaxMind site if this is changed.
   
   This can be tested from Stellar in general, or by spinning up full dev and ensuring both Geo and ASN work and that the newer files are in /apps/metron<geo/asn>/default
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [x] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [x] Have you written or updated unit tests and or integration tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services