You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by GitBox <gi...@apache.org> on 2021/02/14 16:55:25 UTC
[GitHub] [geronimo-txmanager] efge opened a new pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
efge opened a new pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
rzo1 commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-814841322
@jgallimore any results from the tests? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] efge commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
efge commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-778808581
Given the triviality of the implementation for those that need it (a simple lambda for those on Java >= 8) I felt it was not really needed in the base project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] efge removed a comment on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
efge removed a comment on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-783303908
Ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] efge commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
efge commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-818022122
Could someone have a look at merging this, if it's ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rmannibucau commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-778809602
@efge depends how you use it I guess. The normal case will be that you don't instantiate yourself the tx mgr (spring, tomee, .... will do) so you can inject a custom provider and then you need to cast this provider to "set" the time value you want (I assume more than a delta). In such a case it makes sense to have a built in impl use can just configure in tomee.xml or so - but it can also go in tomee integration layer, this is why I put a "?" on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] efge commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
efge commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-804076758
Hi. Is there anything more I should do before this can be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rmannibucau commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-778815348
@jeanouii / @jgallimore any opinion on this one? Do you want to follow up on this PR (on the project itself it is ready to merge IMHO, just want to ensure we don't miss some ecosystem integration, in particular when so easy to get.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] jgallimore commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
jgallimore commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-804116206
It looks ok - I'll run some tests with this change this afternoon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rmannibucau edited a comment on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
rmannibucau edited a comment on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-778815348
@jeanouii / @jgallimore any opinion on this one? Do you want to follow up on this PR (on the project itself it is ready to merge IMHO, just want to ensure we don't miss some ecosystem integration, in particular when so easy to get.
edit: let's wait ~one more week to see if we get feedback otherwise we will integrate it as it (it is holidays there atm so can delay reviews)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] jgallimore commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
jgallimore commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-815281717
This looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] efge commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
efge commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-783303908
Ping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] efge commented on pull request #6: GERONIMO-6805: Use a time SPI abstraction to provide time to the transaction manager
Posted by GitBox <gi...@apache.org>.
efge commented on pull request #6:
URL: https://github.com/apache/geronimo-txmanager/pull/6#issuecomment-778810709
@rmannibucau you know more than me about the various environments in which this may be used so I defer to you on what's more convenient and practical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org