You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/06 05:19:16 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #217:
Refine Kconfig under drivers folder
xiaoxiang781216 opened a new pull request #217: Refine Kconfig under drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217
1.Move subsystem config into sub folder
2.Remove the duplicated if/endif
Change-Id: I0b96ac0570ee1ba62bbb95586381f5410b90bcf0
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #217: Refine Kconfig
under drivers folder
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #217: Refine Kconfig under drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#217: Refine Kconfig under drivers folder
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #217: Refine Kconfig under drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217#discussion_r376644228
##########
File path: drivers/Kconfig
##########
@@ -88,18 +88,6 @@ if CAN
source drivers/can/Kconfig
endif
-config ARCH_HAVE_PWM_PULSECOUNT
- bool
- default n
-
-config ARCH_HAVE_PWM_MULTICHAN
- bool
- default n
-
-config ARCH_HAVE_I2CRESET
- bool
- default n
-
Review comment:
I think this applies in general to all settings of the form ARCH_HAVE_*. They should never be conditioned on anything.
These are simple announcements that the architecture supports a feature and must be unconditional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#217: Refine Kconfig under drivers folder
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #217: Refine Kconfig under drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217#discussion_r376642907
##########
File path: drivers/Kconfig
##########
@@ -88,18 +88,6 @@ if CAN
source drivers/can/Kconfig
endif
-config ARCH_HAVE_PWM_PULSECOUNT
- bool
- default n
-
-config ARCH_HAVE_PWM_MULTICHAN
- bool
- default n
-
-config ARCH_HAVE_I2CRESET
- bool
- default n
-
Review comment:
I believe that it is an error to move ARCH_HAVE_I2CRESET so that it depencds on I2C. There is no dependency on I2C at all. Setting that option simply means that the architecture does dupport I2CRESET. I2C is not needed.
Further, this introduces errors. Abdelatif points out this the causes warnings in the Kconfig files. Since there is absolutely no logical dependency on I2C, architecture configurations select ARCH_HAVE_I2CRESERT (correct) but because of this change, all of this selections now cause un-met dependency warnings incorrect.
The correct fix is to restore the code as it was before (and NOT to add if I2C).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #217: Refine Kconfig under drivers folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #217: Refine Kconfig under drivers folder
URL: https://github.com/apache/incubator-nuttx/pull/217#discussion_r376686006
##########
File path: drivers/Kconfig
##########
@@ -88,18 +88,6 @@ if CAN
source drivers/can/Kconfig
endif
-config ARCH_HAVE_PWM_PULSECOUNT
- bool
- default n
-
-config ARCH_HAVE_PWM_MULTICHAN
- bool
- default n
-
-config ARCH_HAVE_I2CRESET
- bool
- default n
-
Review comment:
@patacongo I will provide a patch move all HAVE to original place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services