You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2017/07/07 11:30:33 UTC
Review Request 60705: ATLAS-1927 : UI - changing the look and feel of
attribute in details page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-1927
https://issues.apache.org/jira/browse/ATLAS-1927
Repository: atlas
Description
-------
Show the attributes of entities in tag format instead of showing comma(,) separator.
Diffs
-----
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 45cdd6b
Diff: https://reviews.apache.org/r/60705/diff/1/
Testing
-------
verified the attributes of entities is showing in tag format instead of showing comma(,) separator.
Thanks,
Kalyani Kashikar
Re: Review Request 60705: ATLAS-1927 : UI - changing the look and
feel of attribute in details page.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/#review180812
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 18, 2017, 11:04 a.m., Kalyani Kashikar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60705/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 11:04 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-1927
> https://issues.apache.org/jira/browse/ATLAS-1927
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Show the attributes of entities in tag format instead of showing comma(,) separator.
>
>
> Diffs
> -----
>
> dashboardv2/public/css/scss/tag.scss fc0652b
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c45755f
> dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 45cdd6b
> dashboardv2/public/js/views/tag/addTagModalView.js 97d80bd
>
>
> Diff: https://reviews.apache.org/r/60705/diff/5/
>
>
> Testing
> -------
>
> verified the attributes of entities is showing in tag format instead of showing comma(,) separator.
>
>
> Thanks,
>
> Kalyani Kashikar
>
>
Re: Review Request 60705: ATLAS-1927 : UI - changing the look and
feel of attribute in details page.
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/
-----------------------------------------------------------
(Updated July 18, 2017, 11:04 a.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
Attribute table size issue fixed and change values alignment based on Data-type.
Bugs: ATLAS-1927
https://issues.apache.org/jira/browse/ATLAS-1927
Repository: atlas
Description
-------
Show the attributes of entities in tag format instead of showing comma(,) separator.
Diffs (updated)
-----
dashboardv2/public/css/scss/tag.scss fc0652b
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c45755f
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 45cdd6b
dashboardv2/public/js/views/tag/addTagModalView.js 97d80bd
Diff: https://reviews.apache.org/r/60705/diff/5/
Changes: https://reviews.apache.org/r/60705/diff/4-5/
Testing
-------
verified the attributes of entities is showing in tag format instead of showing comma(,) separator.
Thanks,
Kalyani Kashikar
Re: Review Request 60705: ATLAS-1927 : UI - changing the look and
feel of attribute in details page.
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/
-----------------------------------------------------------
(Updated July 17, 2017, 11:16 a.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
border added for attribute table.
Bugs: ATLAS-1927
https://issues.apache.org/jira/browse/ATLAS-1927
Repository: atlas
Description
-------
Show the attributes of entities in tag format instead of showing comma(,) separator.
Diffs (updated)
-----
dashboardv2/public/css/scss/tag.scss fc0652b
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c45755f
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 45cdd6b
dashboardv2/public/js/views/tag/addTagModalView.js 97d80bd
Diff: https://reviews.apache.org/r/60705/diff/4/
Changes: https://reviews.apache.org/r/60705/diff/3-4/
Testing
-------
verified the attributes of entities is showing in tag format instead of showing comma(,) separator.
Thanks,
Kalyani Kashikar
Re: Review Request 60705: ATLAS-1927 : UI - changing the look and
feel of attribute in details page.
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/
-----------------------------------------------------------
(Updated July 14, 2017, 12:31 p.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
Remove duplicate attribute from router.js file
Bugs: ATLAS-1927
https://issues.apache.org/jira/browse/ATLAS-1927
Repository: atlas
Description
-------
Show the attributes of entities in tag format instead of showing comma(,) separator.
Diffs (updated)
-----
dashboardv2/public/css/scss/tag.scss fc0652b
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c45755f
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 45cdd6b
dashboardv2/public/js/views/tag/addTagModalView.js 97d80bd
Diff: https://reviews.apache.org/r/60705/diff/3/
Changes: https://reviews.apache.org/r/60705/diff/2-3/
Testing
-------
verified the attributes of entities is showing in tag format instead of showing comma(,) separator.
Thanks,
Kalyani Kashikar
Re: Review Request 60705: ATLAS-1927 : UI - changing the look and
feel of attribute in details page.
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60705/
-----------------------------------------------------------
(Updated July 14, 2017, 10:08 a.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
Updated patch contains changes to render the Tags attribute data in table format. Data is rendered in sorted order and Date/time format is shown for 'Date' data-type.
Bugs: ATLAS-1927
https://issues.apache.org/jira/browse/ATLAS-1927
Repository: atlas
Description
-------
Show the attributes of entities in tag format instead of showing comma(,) separator.
Diffs (updated)
-----
dashboardv2/public/css/scss/tag.scss fc0652b
dashboardv2/public/js/router/Router.js 8a1d241
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c45755f
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 45cdd6b
dashboardv2/public/js/views/tag/addTagModalView.js 97d80bd
Diff: https://reviews.apache.org/r/60705/diff/2/
Changes: https://reviews.apache.org/r/60705/diff/1-2/
Testing
-------
verified the attributes of entities is showing in tag format instead of showing comma(,) separator.
Thanks,
Kalyani Kashikar