You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/04/19 03:33:57 UTC
Review Request: Re-enable baremetal components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10616/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, Kelven Yang, and Frank Zhang.
Description
-------
Baremetal provisioning components were commented out on master - uncommenting them again to allow creation of baremetal clusters.
This addresses bug CLOUDSTACK-2101.
Diffs
-----
client/tomcatconf/applicationContext.xml.in 7487a5e
client/tomcatconf/componentContext.xml.in 7a46981
client/tomcatconf/nonossComponentContext.xml.in 2359ba8
Diff: https://reviews.apache.org/r/10616/diff/
Testing
-------
Creation of a cluster of hypervisor type baremetal succeeds with these changes in.
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: Re-enable baremetal components
Posted by David Nalley <da...@gnsa.us>.
On Thu, Apr 18, 2013 at 11:22 PM, Parth Jagirdar
<Pa...@citrix.com> wrote:
> I think original consensus was to disable Baremetal for 4.1 only.
>
> ŠParth
If my earlier message wasn't clear enough, please consider this my
veto on baremetal being enabled without tests coming in around it.
--David
Re: Review Request: Re-enable baremetal components
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Apr 19, 2013 at 03:22:51AM +0000, Parth Jagirdar wrote:
> I think original consensus was to disable Baremetal for 4.1 only.
Correct, due to the quality issues with the feature and some (probably
well deserved) vacation time requiring that we disable it.
Now's a good time to ask about automated tests though. Wouldn't they help
ensure (1) the quality of the feature before re-enabling it and (2) that we
have a way to regression test it easily?
-chip
Re: Review Request: Re-enable baremetal components
Posted by Parth Jagirdar <Pa...@citrix.com>.
I think original consensus was to disable Baremetal for 4.1 only.
ŠParth
On 4/18/13 6:56 PM, "David Nalley" <da...@gnsa.us> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/10616/#review19428
>-----------------------------------------------------------
>
>
>Baremetal seems to be suffering from a significant lack of unit tests and
>integration tests for marvin to consume. Let's get those in place before
>we consider re-enabling this.
>
>- David Nalley
>
>
>On April 19, 2013, 1:33 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10616/
>> -----------------------------------------------------------
>>
>> (Updated April 19, 2013, 1:33 a.m.)
>>
>>
>> Review request for cloudstack, Chip Childers, Kelven Yang, and Frank
>>Zhang.
>>
>>
>> Description
>> -------
>>
>> Baremetal provisioning components were commented out on master -
>>uncommenting them again to allow creation of baremetal clusters.
>>
>>
>> This addresses bug CLOUDSTACK-2101.
>>
>>
>> Diffs
>> -----
>>
>> client/tomcatconf/applicationContext.xml.in 7487a5e
>> client/tomcatconf/componentContext.xml.in 7a46981
>> client/tomcatconf/nonossComponentContext.xml.in 2359ba8
>>
>> Diff: https://reviews.apache.org/r/10616/diff/
>>
>>
>> Testing
>> -------
>>
>> Creation of a cluster of hypervisor type baremetal succeeds with these
>>changes in.
>>
>>
>> Thanks,
>>
>> Venkata Siva Vijayendra Bhamidipati
>>
>>
>
Re: Review Request: Re-enable baremetal components
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10616/#review19428
-----------------------------------------------------------
Baremetal seems to be suffering from a significant lack of unit tests and integration tests for marvin to consume. Let's get those in place before we consider re-enabling this.
- David Nalley
On April 19, 2013, 1:33 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10616/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 1:33 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Kelven Yang, and Frank Zhang.
>
>
> Description
> -------
>
> Baremetal provisioning components were commented out on master - uncommenting them again to allow creation of baremetal clusters.
>
>
> This addresses bug CLOUDSTACK-2101.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 7487a5e
> client/tomcatconf/componentContext.xml.in 7a46981
> client/tomcatconf/nonossComponentContext.xml.in 2359ba8
>
> Diff: https://reviews.apache.org/r/10616/diff/
>
>
> Testing
> -------
>
> Creation of a cluster of hypervisor type baremetal succeeds with these changes in.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>